sha2: test builds on 32-bit Linux and macOS/x86-64 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
sha2/test-linux-mac-windows-cross
branch
2 times, most recently
from
3083f28
to
4cc5ce0
Compare
Per #207 it seems we aren't doing enough testing, particularly for the `asm` feature on various platforms. This commit adds much more extensive testing for the `sha2` crate in particular, since it's one of the most important.
tarcieri
force-pushed
the
sha2/test-linux-mac-windows-cross
branch
from
4cc5ce0
to
b418464
Compare
tarcieri
changed the title
|
The Windows and cross-based tests are failing for whatever reason. That probably warrants some further investigation, however for now we can at least expand the coverage a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #207 it seems we aren't doing enough testing, particularly for the
asmfeature on various platforms.This commit adds much more extensive testing for the
sha2crate in particular, since it's one of the most important.