fix: wrong token for cache #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjtang1985
requested changes
Nov 5, 2021
packages/core/src/connectivity/scp-cf/destination/destination-cache.spec.ts
Outdated
Show resolved
Hide resolved
| @@ -570,10 +570,6 @@ class DestinationFromServiceRetriever { | |||
| return false; | |||
| } | |||
|
|
|||
| if (this.isProviderAndSubscriberSameTenant()) { | |||
FrankEssenberger
commented
Nov 5, 2021
packages/core/src/connectivity/scp-cf/destination/destination-cache.spec.ts
Show resolved
Hide resolved
# Conflicts: # packages/core/src/connectivity/scp-cf/destination/destination-cache.spec.ts
jjtang1985
approved these changes
Nov 5, 2021
This was referenced Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of what your change does and why it is needed.
Closes SAP/cloud-sdk-backlog#437.
Under some condition the wrong token was used to build the cache. The removed tests were misleading because the passed token from the user can be from the subscriber or provider account.