Fix: destination cache vulnerablity #1770 #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ | |||
|
|
|||
| ## Fixed Issues | |||
|
|
|||
| - | |||
| - [core] Disable destination cache, when the JWT does not contain necessary information. For example, when using `IsolationStrategy.Tenant_User`, the JWT has to contain both tenant id and user id. | |||
There was a problem hiding this comment.
Sorry I forgot to put my sentence there from #1769. Could you add it?
|
@jjtang1985 could you merge master. Then a few tests should fail, because I adjusted the service keys not containing the user_id (to reproduce the error), but only your change do avoid the cache beeing used in this case. |
FrankEssenberger
approved these changes
Nov 8, 2021
FrankEssenberger
approved these changes
Nov 8, 2021
|
Remarks are added => approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry picks the the commit #1770 and removed some deprecated functions.