[FIX] Bundling: Detect manifest.json dependency of Components / Libraries #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeworrior
reviewed
Jul 14, 2023
| @@ -54,6 +54,7 @@ class ComponentAnalyzer { | |||
| try { | |||
| const manifestResource = await this._pool.findResource(manifestName).catch(() => null); | |||
| if ( manifestResource ) { | |||
| info.addDependency(manifestName); | |||
There was a problem hiding this comment.
I think we need to discuss whether the existence of a manifest.json should be the indicator or the manifest: json entry in the metadata or both.
- If a manifest.json exists, manifest-first would work even if the component does not have the metadata entry
- if the metadata entry exists, a manifest.json would be requested even if it doesn't exist
There was a problem hiding this comment.
I agree. My idea was to always add the dependency because currently the manifest.json is always taken into account for dependency analysis.
I suggest to merge this change as-is and to follow-up on the ComponentAnalyzer as a whole, which also seems to lack detection of new features (e.g. in routing).
There was a problem hiding this comment.
I've created #954 which only covers libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.