[FIX] Bundling: Detect manifest.json dependency of libraries #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the problem of missing manifest.json files of libraries in bundles, such as sap-ui-custom.js (self-contained build). It also eliminates the need to explicitly mention manifest.json files of libraries to be included in custom bundles.
matz3
force-pushed
the
lbt-detect-manifest-json-deps-library
branch
from
5317930 to
cb84e38
Compare
|
LGTM but I think @codeworrior should have a look too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the problem of missing manifest.json files of libraries in
bundles, such as sap-ui-custom.js (self-contained build).
It also eliminates the need to explicitly mention manifest.json files
of libraries to be included in custom bundles.