Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error from popup #261

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: error from popup #261

merged 2 commits into from
Jan 23, 2024

Conversation

kineticjs
Copy link
Contributor

Issue:
Empty popup upon pressing the pageAction, due to error in processing its request to inject content script into the page [that obtains more information about the page].
The error is thrown because the request does not contain "frameId", so it passed to chrome.scripting.executeScript a "frameId" with the invalid value of "undefined"

Solution:
The page action should be showing information about the main frame. Given that scripting.executeScript selects the main frame by default, only ensure that no "frameId" with the invalid value of "undefined" is passed to it

@kineticjs kineticjs merged commit a268e82 into SAP:master Jan 23, 2024
3 checks passed
@kineticjs
Copy link
Contributor Author

Thanks

Copy link
Contributor

🎉 This PR is included in version 1.6.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants