Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error from popup #261

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: error from popup #261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da6466
fix: error from popup
kineticjs Jan 17, 2024
cf403ba
Merge remote-tracking branch 'origin/master' into fix-error-from-popup
kineticjs Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions app/scripts/background/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,20 @@
* @param {Object} message
*/
'do-script-injection': function (message) {
const frameId = message.frameId;
chrome.windows.getCurrent().then(w => {
chrome.tabs.query({ active: true, windowId: w.id }).then(tabs => {
const target = {
tabId: tabs[0].id
};
// inject the script only into the frame
// specified in the request from the devTools UI5 panel script;
// If no frameId specified, the script will be injected into the main frame
if (frameId !== undefined) {
target.frameIds = [message.frameId];
}
chrome.scripting.executeScript({
target: {
// inject the script only into the frame
// specified in the request from the devTools UI5 panel script
tabId: tabs[0].id, frameIds: [message.frameId]
},
target,
files: [message.file]
});
});
Expand Down
Loading