-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted dev scripts to ESM modules #720
Conversation
Hey @KolCrooks, EDIT: sorry, just realized that I already have write access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like jest serializers have to be in cjs
format, so could you please revert the changes in both serializers (marked as PR comment) and rename them to use the .cjs
file extension?
Then you have to update the imports in config/jestsetup.ts
to match the new .cjs
file extension:
import contentLoaderSerializer from '@shared/tests/serializer/content-loader-serializer.cjs';
import jssSerializer from '@shared/tests/serializer/jss-snapshot-serializer.cjs';
Other than that everything looks good and we can merge this PR as soon as all CI jobs are passing.
Thanks!
@MarcusNotheis I'm sorry that I haven't been able to work on this / not giving a heads up. I got hit with a ton of work and midterms from uni so It has been tough for me to find time to do things like this. |
Key @KolCrooks, Best regards, |
I converted the dev scripts to ESM modules as talked about in #701.