Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-icon should work with message bundles from the actual icons package #2739

Closed
1 of 2 tasks
pskelin opened this issue Jan 28, 2021 · 1 comment · Fixed by #2816
Closed
1 of 2 tasks

ui5-icon should work with message bundles from the actual icons package #2739

pskelin opened this issue Jan 28, 2021 · 1 comment · Fixed by #2816
Assignees
@ilhan007 @vladitasev
Labels
enhancement New feature or request TOPIC Core
Milestone
1.0.0-rc.13

Comments

@pskelin
Copy link
Contributor

pskelin commented Jan 28, 2021 •
edited by ilhan007
Loading

right now, the ui5-icon component is fetching translations from the main package like this:
fetchI18nBundle("@ui5/webcomponents");

this also means that the icons package contains a message bundle that no one uses, and the main package contains texts that do not belong there.

this feature should include:

  • the icon component should load message bundles from the relevant icon package - example icon tnt/workflow-editor should look up texts from @ui5/webcomponents/icons-tnt
  • the texts for icons should be removed from the main package
@ilhan007 ilhan007 added TOPIC Core enhancement New feature or request labels Jan 28, 2021
@ilhan007 ilhan007 added this to the 1.0.0-rc.13 milestone Jan 28, 2021
@ilhan007 ilhan007 self-assigned this Jan 29, 2021
@ilhan007 ilhan007 mentioned this issue Jan 29, 2021
Merged
ilhan007 added a commit that referenced this issue Jan 29, 2021
@ilhan007
chore(icons): move i18ns to icons package & add acc texts (#2751)
9129f45 
The Icon component now loads message bundles from the relevant icon package
The icons i18n texts are removed from the main package and added to the icons package
Accessibility texts are added for more icons (about 60), for each that we had key-value entry in the message bundle (prior to this change only 4 used to have such)
Related to: #2739
alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this issue Feb 1, 2021
@ilhan007 @alexandar-mitsev
chore(icons): move i18ns to icons package & add acc texts (SAP#2751)
50d4c36 
The Icon component now loads message bundles from the relevant icon package
The icons i18n texts are removed from the main package and added to the icons package
Accessibility texts are added for more icons (about 60), for each that we had key-value entry in the message bundle (prior to this change only 4 used to have such)
Related to: SAP#2739
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this issue Feb 9, 2021
@ilhan007 @NHristov-sap
chore(icons): move i18ns to icons package & add acc texts (SAP#2751)
e7b2be1 
The Icon component now loads message bundles from the relevant icon package
The icons i18n texts are removed from the main package and added to the icons package
Accessibility texts are added for more icons (about 60), for each that we had key-value entry in the message bundle (prior to this change only 4 used to have such)
Related to: SAP#2739
@vladitasev
Copy link
Contributor

#2816

@vladitasev vladitasev self-assigned this Feb 12, 2021
@vladitasev vladitasev mentioned this issue Feb 12, 2021
Merged
@petyabegovska petyabegovska moved this to Completed in Planning - Topic Core Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

@vladitasev vladitasev

Labels
enhancement New feature or request TOPIC Core
Projects
Planning - Topic Core
Status: Completed
Milestone
1.0.0-rc.13
Development

Successfully merging a pull request may close this issue.

fix(ui5-icon): ui5-icon i18n works for all packages SAP/ui5-webcomponents
3 participants
@pskelin @ilhan007 @vladitasev