chore(icons): move i18ns to icons package & add acc texts #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
pskelin
approved these changes
Jan 29, 2021
| @@ -181,7 +181,7 @@ class Icon extends UI5Element { | |||
|
|
|||
| static async onDefine() { | |||
| this.createGlobalStyle(); // hide all icons until the first icon has rendered (and added the Icon.css) | |||
| await fetchI18nBundle("@ui5/webcomponents"); | |||
| await fetchI18nBundle("@ui5/webcomponents-icons"); | |||
There was a problem hiding this comment.
This change is a good first step, but please don't close the issue as the ui5-icon web component is still hardcoding where the message bundles are coming from.
For a generic solution, we also need to think of a mapping from icon namespace to icon package.
For example, the icon tnt/workflow-editor should look up texts from @ui5/webcomponents/icons-tnt.
I'll add this to the issue.
alexandar-mitsev
pushed a commit
to alexandar-mitsev/ui5-webcomponents
that referenced
this pull request
Feb 1, 2021
The Icon component now loads message bundles from the relevant icon package The icons i18n texts are removed from the main package and added to the icons package Accessibility texts are added for more icons (about 60), for each that we had key-value entry in the message bundle (prior to this change only 4 used to have such) Related to: SAP#2739
NHristov-sap
pushed a commit
to NHristov-sap/ui5-webcomponents
that referenced
this pull request
Feb 9, 2021
The Icon component now loads message bundles from the relevant icon package The icons i18n texts are removed from the main package and added to the icons package Accessibility texts are added for more icons (about 60), for each that we had key-value entry in the message bundle (prior to this change only 4 used to have such) Related to: SAP#2739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Related to: #2739