Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-dialog: scrolling is blocked when dialog is closed with Esc key #3690

Closed
1 of 4 tasks
MarcusNotheis opened this issue Aug 19, 2021 · 1 comment · Fixed by #3696
Closed
1 of 4 tasks

ui5-dialog: scrolling is blocked when dialog is closed with Esc key #3690

MarcusNotheis opened this issue Aug 19, 2021 · 1 comment · Fixed by #3696
Assignees
Labels

Comments

@MarcusNotheis
Copy link
Collaborator

MarcusNotheis commented Aug 19, 2021

Bug Description

If a ui5-dialog is closed with the Escape key, it seems like it doesn't remove the scroll blocking. If you close if the the close() method, the scroll blocking gets removed as expected.

Expected Behavior

Scroll Blocking should be removed when closing the dialog via Esc, like in 1.0.0-rc.14.

Steps to Reproduce

  1. Open: https://codesandbox.io/s/thirsty-bouman-cb80u?file=/src/App.js
  2. Scroll through the page, everything is working fine.
  3. Click Open Dialog, close it with the close button in the footer, try to scroll again. --> Still works fine
  4. Click Open Dialog again, then press Esc and try to scroll again. --> Scrolling is now blocked
  5. Optional: open the dialog again and press the close button, scrolling works fine again

Isolated Example

https://codesandbox.io/s/thirsty-bouman-cb80u?file=/src/App.js

Context

  • UI5 Web Components version: 1.0.0-rc.15
  • OS/Platform: macOS
  • Browser: Chrome 92.0.4515.131
  • Affected component: ui5-dialog, maybe even the base class ui5-popup?

Priority

  • Low
  • Medium
  • High
  • Very High

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: SAP Customer Advisory / UI5 Web Components for React
@unazko unazko self-assigned this Aug 19, 2021
@unazko unazko added bug This issue is a bug in the code High Prio TOPIC RD labels Aug 19, 2021
@unazko
Copy link
Contributor

unazko commented Aug 19, 2021

Hello @SAP/ui5-webcomponents-topic-rd,

The issue is reproducible via the provided steps.

Regards,
Boyan

@unazko unazko removed their assignment Aug 19, 2021
@dimovpetar dimovpetar self-assigned this Aug 19, 2021
ilhan007 pushed a commit that referenced this issue Aug 25, 2021
Body scrolling is now blocked only on first call of blockBodyScrolling and restored on the last call of unblockBodyScrolling.

Fixes #3690
ilhan007 pushed a commit that referenced this issue Sep 10, 2021
Body scrolling is now blocked only on first call of blockBodyScrolling and restored on the last call of unblockBodyScrolling.

Fixes #3690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants