-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-dialog): correctly restore body scrolling on ESC #3696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also fix OpenedPopupsRegistry.js, line 38 should be
openedRegistry[openedRegistry.length - 1].instance.close(true);
instead of
openedRegistry.pop().instance.close(true);
this on its own is also fixing the issue, but can be fixed in combination
You are right, I've changed the OpenedPopupsRegistry to not implicitly remove the popup. |
Hi colleagues, could you kindly also include this in the next release of the |
Hi @Lukas742 yes, we will do that |
Body scrolling is now blocked only on first call of blockBodyScrolling and restored on the last call of unblockBodyScrolling. Fixes #3690
Body scrolling is now blocked only on first call of
blockBodyScrolling
and restored on the last call ofunblockBodyScrolling
.Fixes #3690