TextArea: max length text is cut short when using rows=1, required field has no effect

[rchrdchn]

Describe the bug
A clear and concise description of what the bug is.

Isolated Example
https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-textarea--default-story

To Reproduce
Steps to reproduce the behavior:

1. Go to ui5-webcomponents-react TextArea playground
2. Change the following properties: rows='1' and maxlength='100'
3. See how 100 characters remaining text is cut short

Expected behavior
Max length to be fully displayed height-wise

Screenshots

UI5 Web Components for React Information
@ui5/webcomponents-react version: @ui5/webcomponents-react - v0.18.11

[Lukas742]

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Hi colleagues,
additionally to what @rchrdchn has described the counter below the input is only displayed when using showExceededText and I'm not sure if this is intended or not. Also a scrollbar will be displayed inside the TextArea with and without showExceededText applied.
See codeSandbox

[nnaydenow]

Hello @SAP/ui5-webcomponents-topic-rl ,

The issue is reproducible in master version show-exceeded-text, rows=1 and some number for maxlength.

Regards,
Nayden

[rchrdchn]

TextArea's required prop does not seem to be working. Could you check on this as well, please?

[d3xter666]

Hi @rchrdchn ,

Could you elaborate on that? What is your expectation for a working required attribute?

Cheers

[rchrdchn]

Hi @d3xter666 - the TextArea field does not display any error handling warning/message when the field is empty on a form/dialog that has the required property on the component.

I believe the expectation would be to signal some sort of warning message or state when a user leaves the required TextArea field empty and tries to submit a form.

[Lukas742]

Hi @rchrdchn @d3xter666

the issue with the required property could be related to this issue: #3498

[d3xter666]

Hi @rchrdchn ,

I believe this should be somehow application logic.
Probably you mean that formElement.checkValidity() does not work as expected?

@vladitasev Could you help a bit with the required property? Is it something that needs to be handled by app developers or by the framework? Am I missing something here?

Cheers

[rchrdchn]

the issue with the required property could be related to this issue: #3498

Yes, thanks! It seems like they are related with one difference that #4142 is for TextArea, while #3498 is for Input

[rchrdchn]

Hi @Lukas742 - just wanted to follow-up on this issue and wondering what's the ETA for fixing this issue. Thank you!

[Lukas742]

Hi @rchrdchn

I'm not part of the UI5 Web Components team, so I can't really answer this question, but since this issue has just been closed and the linked PR has already been merged, I would assume that the fix should be available with the next release.

@d3xter666 am I correct in my assumption?

[niyap]

Hello Colleagues,

The issue is fixed in the master and the change is merged. Also, change for version 0.31 is prepared and is in validation phase. As soon as possible, it will be available in 0.31 as well.

Kind Regards,
Niya

[rchrdchn]

Thank you @Lukas742 and @niyap! Our team will made changes accordingly when it's available on 0.31.

[niyap]

Hello @rchrdchn,

The solution is now available in 0.31. Here is a reference to the change: #4417

Kind Regards,
Niya

[ilhan007]

Hello @rchrdchn,

the fix is downported to the 0.31 branch, but not released, next patch will be available next week

[ilhan007]

Hello @rchrdchn
the fix released is released - use the 0.31.27 version.