fix(ui5-textarea): Calc properly TextArea's size for showExceeds property #4152
Conversation
…erty When showExceeds property was used, remainning characters text's size was not taken into consideration for TextArea's root height calculations.
d3xter666
requested review from
MapTo0,
hristop,
elenastoyanovaa,
ndeshev and
niyap
There was a problem hiding this comment.
Let's leave it with the magic number 32, as it looks better.
I will propose you to add a sample showing the use case : ui5-textarea with showExceededText property set to true and rows="1". Because,we could not add tests, since currently we do not have visual tests and if somebody makes a change in these calculations, I am sure that he will not have in mind to test that use case :)
HI @niyap , Just added a sample in the test page. Cheers |
| <br> | ||
| <ui5-textarea id="textarea-single-row" | ||
| show-exceeded-text="true" | ||
| growing-max-lines="0" |
There was a problem hiding this comment.
"growing" property is false by default, so without adding it, growing-max-lines does not influence the component. Also, 0 is the default value, so you do not have to specify it.
…erty (#4152) * fix(ui5-textarea): Calc properly TextArea's size for showExceeds property When showExceeds property was used, remainning characters text's size was not taken into consideration for TextArea's root height calculations. * Fix eslint errors * Add single row textarea sample * Update sample
…erty (#4152) (#4417) * fix(ui5-textarea): Calc properly TextArea's size for showExceeds property When showExceeds property was used, remainning characters text's size was not taken into consideration for TextArea's root height calculations. * Fix eslint errors * Add single row textarea sample * Update sample Co-authored-by: Yavor Ivanov <d3xter666@users.noreply.github.com>
Fixes: #4142
When showExceeds property was used, remainning characters text's size was not taken into consideration
for TextArea's root height calculations.