Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-calendar): keyboard handling now compliant with the specification #3635

Closed
wants to merge 14 commits into from
Closed

fix(ui5-calendar): keyboard handling now compliant with the specification #3635

wants to merge 14 commits into from

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Aug 11, 2021 •
edited
Loading

  • Pressing F4 opens a month picker in all cases.
  • Pressing Shift and F4 opens a year picker in all cases.
  • Changing the month or the year via mouse now moves focus
    to the todays date in the day picker.
  • Pressing Alt and Page Up now does the same as pressing Shift and Page Up.
  • Pressing Alt and Page Down now does the same as pressing Shift and Page Down.

Related to: #3091

@unazko
fix(ui5-calendar): keyboard handling now compliant with the specifica…
a6eee02 
…tion

- Pressing F4 opens a month picker in all cases.
- Pressing Shift and F4 opens a year picker in all cases.
- Chaning the month or the year via mouse now moves focus
to the todays date in the day picker.
- Pressing Alt and Page Up now does the same as pressing Shift and Page Up.
- Pressing Alt and Page Down now does the same as pressing Shift and Page Down.

Fixes SAP#3091
@unazko unazko requested review from vladitasev, tsanislavgatev, ilhan007 and fifoosid and removed request for tsanislavgatev August 11, 2021 14:29
dependabot bot added 2 commits August 11, 2021 20:40
@dependabot
chore(deps): bump lodash from 4.17.19 to 4.17.21 in /packages/playgro…
63e19d1 
…und (SAP#3212)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.19...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump hosted-git-info in /packages/playground (SAP#3213)
7cdcb4d 
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.7.1 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.7.1...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@unazko unazko removed the request for review from vladitasev August 11, 2021 17:49
unazko and others added 7 commits August 11, 2021 18:49
@unazko
fix(ui5-date-picker): keyboard handling now compliant with the specif…
24467f8 
…ication (SAP#3636)

- Focus is moved on the component input field after closing
the corresponding popover via Escape keyboard key.

Fixes SAP#3091
@dependabot
chore(deps): bump ws from 7.4.4 to 7.5.3 (SAP#3637)
27a2fb8 
Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.5.3.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.4.4...7.5.3)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9 (SAP#3422)
e8fd8a7 
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

---
updated-dependencies:
- dependency-name: hosted-git-info
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump y18n from 3.2.1 to 3.2.2 in /packages/playground (S…
7d89d5a 
…AP#3040)

Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump postcss from 8.2.8 to 8.2.10 (SAP#3218)
b480f7f 
Bumps [postcss](https://github.com/postcss/postcss) from 8.2.8 to 8.2.10.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.2.8...8.2.10)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@nnaydenow
feat(ui5-illustrated-message): introduce subtitle slot (SAP#3633)
96ccf93 
Closes: SAP#3557
Fixes: SAP#3557
@vladitasev
refactor(framework): UI5Element - improvements and fixes (SAP#3604)
bef62af
@ilhan007 ilhan007 requested a review from a team August 12, 2021 09:47
service-tip-git and others added 2 commits August 12, 2021 12:48
@service-tip-git
chore: translation delivery (SAP#3638)
66688ee 
Change-Id: I4fb2c5812f80d5b3eb824ea3d1bf5a2cb4983912
@unazko
fix(ui5-date-picker): internal calendar component state managed prope…
6a820a6 
…rly (SAP#3641)

Day picker is always shown when the corresponding ui5-date-picker,
ui5-datetime-picker or ui5-daterange-picker component popover is opened.
@ilhan007
Copy link
Member

There is merge conflict and also someone from @SAP/ui5-webcomponents-topic-b should also review the change.

@unazko unazko closed this Aug 12, 2021
@unazko unazko deleted the calendar_kbh branch August 12, 2021 21:14
@unazko
Copy link
Contributor Author

unazko commented Aug 12, 2021 •
edited
Loading

Messed up the merge.
I've closed the current pull request and created a new: #3649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 Awaiting requested review from ilhan007

@fifoosid fifoosid Awaiting requested review from fifoosid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@unazko @ilhan007 @nnaydenow @vladitasev @service-tip-git