Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-calendar): keyboard handling now compliant with the specification #3649

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Aug 12, 2021

  • Pressing F4 opens a month picker in all cases.
  • Pressing Shift and F4 opens a year picker in all cases.
  • Changing the month or the year via mouse now moves focus
    to the todays date in the day picker.
  • Pressing Alt and Page Up now does the same as pressing Shift and Page Up.
  • Pressing Alt and Page Down now does the same as pressing Shift and Page Down.

Related to: #3091

…tion

- Pressing F4 opens a month picker in all cases.
- Pressing Shift and F4 opens a year picker in all cases.
- Changing the month or the year via mouse now moves focus
to the todays date in the day picker.
- Pressing Alt and Page Up now does the same as pressing Shift and Page Up.
- Pressing Alt and Page Down now does the same as pressing Shift and Page Down.

Related to: SAP#3091
@unazko unazko requested a review from ilhan007 August 12, 2021 21:17
@unazko unazko requested a review from tsanislavgatev August 13, 2021 07:54
@tsanislavgatev
Copy link
Contributor

tsanislavgatev commented Aug 13, 2021

It's okay on our team side, if the core team is okay with the change we can merge it.

@ilhan007 ilhan007 merged commit 768d1e7 into SAP:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants