Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New converter #1151

Merged
merged 253 commits into from
Aug 22, 2020
Merged

New converter #1151

merged 253 commits into from
Aug 22, 2020

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Sep 2, 2019 •
edited
Loading

Our new, versatile Genie->openage converter, featuring the nyan API. This will replace the old converter structure and create the files used for the new gamestate and renderer. Changes listed below

nyan:

  • nyan structures module to create objects and members
  • nyan API module (for accessing API objects)

convert:

  • Readers for AoE1:DE and AoE2:DE
  • New media file conversion (Enhanced singlefile conversion and support for DE1 formats #1148)
  • Conversion processes for Genie objects -> Nyan API objects
    • Pre-processing
    • Refactoring
      • Squashing (merging a unit line into a single object + upgrades)
      • Packing (merging many different unit object into a single unit object with different states, eg. villagers, trebuchets)
      • Trimming (removing unnecessary units by squashing or packing, e.g. monk with relic)
    • Transition (Genie object --> Nyan API object)
      • Abilities
      • Modifiers
      • Techs
      • Civs
  • Media Export
  • Modpack definition and output

@heinezen heinezen added lang: python Done in Python code area: assets Involved with assets (images, sounds, ...) area: api Related to some application programming interface (API) big stuff High-impact changes, mainly foundation work labels Sep 2, 2019
@heinezen heinezen self-assigned this Sep 2, 2019
@heinezen heinezen added this to the Modding API milestone Sep 6, 2019
@heinezen heinezen mentioned this pull request Sep 21, 2019
Merged
@heinezen heinezen force-pushed the new-converter branch 4 times, most recently from 5845051 to 6d93a4a Compare October 23, 2019 00:28
@heinezen heinezen mentioned this pull request Nov 12, 2019
Closed
@heinezen heinezen force-pushed the new-converter branch 2 times, most recently from 204a0d4 to 0540d2f Compare January 15, 2020 07:16
@heinezen heinezen mentioned this pull request Jan 17, 2020
Closed
@brisvag brisvag mentioned this pull request Jan 28, 2020
Closed
@heinezen heinezen mentioned this pull request Feb 16, 2020
Closed
@heinezen heinezen force-pushed the new-converter branch 6 times, most recently from 9ba6514 to 0ad3191 Compare March 8, 2020 05:35
@SFTbot
Copy link

SFTbot commented Mar 17, 2020

This pull request has been mentioned on openage Forum. There might be relevant details there:

https://openage.discourse.group/t/openage-converter-progress-report/87/1

@TheJJ TheJJ added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Aug 21, 2020
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Aug 21, 2020
@TheJJ TheJJ added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Aug 21, 2020
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Aug 21, 2020
TheJJ
TheJJ requested changes Aug 21, 2020
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else is crap 💩

doc/building.md Outdated Show resolved Hide resolved
doc/code/converter/workflow.md Outdated Show resolved Hide resolved
libopenage/gamestate/game_spec.cpp Outdated Show resolved Hide resolved
openage/convert/deprecated/struct_definition.py Show resolved Hide resolved
openage/convert/entity_object/export/formats/modpack_info.py Show resolved Hide resolved
openage/convert/entity_object/export/formats/sprite_metadata.py Show resolved Hide resolved
openage/convert/processor/export/slp_converter_pool.py Outdated Show resolved Hide resolved
openage/convert/service/init/changelog.py Show resolved Hide resolved
openage/convert/value_object/read/media/blendomatic.py Outdated Show resolved Hide resolved
openage/convert/value_object/read/media/blendomatic.py Show resolved Hide resolved
TheJJ
TheJJ approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wheeeee 🥇

@TheJJ TheJJ merged commit 0c41df0 into SFTtech:master Aug 22, 2020
This was referenced Aug 22, 2020
Closed
Closed
@MayeulC
Copy link
Contributor

MayeulC commented Aug 22, 2020

I guess the wrapup is in https://blog.openage.dev/the-openage-converter-part-iv-conclusions.html and https://blog.openage.dev/new-gamestate-2020.html ?

I'm putting these links here for discoverability.

@heinezen
Copy link
Member Author

@MayeulC Thanks :D

This was referenced Sep 4, 2020
Merged
Merged
Closed
@heinezen heinezen mentioned this pull request Jun 24, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees

@heinezen heinezen

Labels
area: api Related to some application programming interface (API) area: assets Involved with assets (images, sounds, ...) big stuff High-impact changes, mainly foundation work lang: python Done in Python code
Projects
None yet
Milestone
Modding API
6 participants
@heinezen @SFTbot @simonsan @MayeulC @TheJJ @brisvag