Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non parallel workflow for integration testing #20

Merged
merged 13 commits into from
Oct 29, 2021
Merged

Allow non parallel workflow for integration testing #20

merged 13 commits into from
Oct 29, 2021

Conversation

vinferrer
Copy link
Member

Closes #13 .

Changes proposed in this pull request:

  • if njobs is 0 allows non parallel workflow for the toolbox testing
  • Now all scripts paths in deconvolution folder detect the parent directory automatically
  • compute_slars.sh accepts positional arguments

@vinferrer vinferrer requested a review from eurunuela October 29, 2021 07:24
@vinferrer vinferrer added enhancement New feature or request testing labels Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021 •
edited
Loading

Codecov Report

Merging #20 (d112ffe) into main (c46babf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   49.26%   49.26%           
=======================================
  Files           3        3           
  Lines         205      205           
=======================================
  Hits          101      101           
  Misses        104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46babf...d112ffe. Read the comment docs.

eurunuela
eurunuela requested changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a transpose that should not be there. Also, why do you force numpy arrays and matrices if the variables are already numpy matrices?

connPFM/deconvolution/compute_slars.sh Show resolved Hide resolved
connPFM/deconvolution/compute_slars.sh Show resolved Hide resolved
connPFM/deconvolution/stability_lars.py Outdated Show resolved Hide resolved
connPFM/deconvolution/compute_slars.py Outdated Show resolved Hide resolved
@vinferrer vinferrer requested a review from eurunuela October 29, 2021 08:37
eurunuela
eurunuela approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vinferrer !

@eurunuela eurunuela merged commit 8825f7f into SPiN-Lab:main Oct 29, 2021
@vinferrer vinferrer deleted the np_workflow branch November 4, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow non parallelized pipeline for testing
2 participants
@vinferrer @eurunuela