Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STDD-21: Compile styles #10

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

mifonBejenari
Copy link
Contributor

READY FOR REVIEW

Summary

  • Compiled css for previous PR

Review By (Date)

Criticality

  • transportationd9.sites.stanford.edu

Urgency

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Go to /marguerite
  4. Verify flags in cards and borders: image
  5. Go to any subpage (ex: /marguerite/y)
  6. Verify flags aligned with page title:
    image

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

Resources

Copy link
Contributor

@buttonwillowsix buttonwillowsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS

@buttonwillowsix buttonwillowsix merged commit 7e4808e into SU-SWS:1.x Sep 4, 2024
1 check failed
@sherakama
Copy link
Member

Is the source code that changed the compiled code missing from this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants