Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STDD-21: Shuttle cards colors #9

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

mifonBejenari
Copy link
Contributor

@mifonBejenari mifonBejenari commented Aug 29, 2024

READY FOR REVIEW

Summary

  • Create styles and functionality to highlight Shuttle flag, and color

Review By (Date)

  • When does this need to be reviewed by?

Criticality

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to /marguerite and
  4. Verify card styles:
    image
  5. Navigate to pages from this list (ex: marguerite/rwc)
  6. Verify flag from title:
    image

Site Configuration Sync

  • No config changes

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

Associated Issues and/or People

  • JIRA ticket(s) - STDD-21
  • Adjust color and "flag label" dependent to card Title. Rewrite default pattern-card template to pass flag label to CSS. Adjust border and flag color by old site

Resources

@buttonwillowsix buttonwillowsix merged commit e547a0c into SU-SWS:1.x Aug 29, 2024
1 check failed
@mifonBejenari mifonBejenari mentioned this pull request Sep 4, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants