Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section #239

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Mar 4, 2024

READY FOR REVIEW

Summary

  • Add optional CTA(s) region after Section and Homepage Theme/Story Section components

Review By (Date)

  • Retro

Criticality

  • 4

Review Tasks

Setup tasks and/or behavior to test

  1. Pull down locally and go to test/yvonne-test-volunteer-leadership-summit
  2. Scroll down to below the photo section
  3. See that you can add CTA(s) at the bottom of the section that are center aligned like this
    Screenshot 2024-03-04 at 2 17 55 PM
  4. Go to test/home-new-test
  5. Scroll to the bottom of the Preparing Citizens section
  6. CHeck that you can also add CTA(s) at the bottom
    Screenshot 2024-03-04 at 2 26 19 PM

Associated Issues and/or People

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit 36f2433
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/65e649fb29f8d400081ab02c
😎 Deploy Preview https://deploy-preview-239--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yvonnetangsu
Copy link
Member Author

This is very low risk so I'm going to merge this in @sherakama 🤠

@yvonnetangsu yvonnetangsu merged commit fb1c80c into dev Mar 4, 2024
5 checks passed
@yvonnetangsu yvonnetangsu deleted the feature/GIVCAMP-304_section-cta-region branch March 4, 2024 22:29
@yvonnetangsu yvonnetangsu mentioned this pull request Mar 5, 2024
yvonnetangsu added a commit that referenced this pull request Mar 6, 2024
* dev:
  1.2.2
  GIVCAMP-294 | Basic Hero overlay options and image optimization (#243)
  HSTS set max-age to 31536000 (#242)
  1.2.1
  Icon animation (#240)
  GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239)
yvonnetangsu added a commit that referenced this pull request Apr 2, 2024
* dev: (34 commits)
  GIVCAMP-292 GIVCAMP-305 | Horizontal Initiative card and image aspect ratio options (#256)
  1.3.3
  Update robots to use different URL for sitemap path (#254)
  1.3.2
  GIVCAMP-307 | Stacked story hero variant (#251)
  1.3.1
  GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options (#248)
  Bump follow-redirects from 1.15.4 to 1.15.6 (#249)
  1.3.0
  GIVCAMP-289: Inline External Script Loading. (#246)
  GIVCAMP-88 | data card (#245)
  1.2.2
  GIVCAMP-294 | Basic Hero overlay options and image optimization (#243)
  HSTS set max-age to 31536000 (#242)
  1.2.1
  Icon animation (#240)
  GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239)
  1.2.0
  GIVCAMP-293 | Moment poster (#236)
  NoJira: Remove Editor Token (#237)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant