Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIVCAMP-307 | Stacked story hero variant #251

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Mar 19, 2024

READY FOR REVIEW

Summary

  • New stacked story hero variant

Review By (Date)

  • Retro

Criticality

  • 5

Review Tasks

Setup tasks and/or behavior to test

  1. Go to Storyblok page test/test-stories/yvonne-test-arts-feature
  2. Select PR 251 from the Storyblok visual editor
  3. Play with the hero options
  4. Go to the Netlify preview https://deploy-preview-251--giving-campaign.netlify.app/
  5. Look at several existing stories and check that they look the same as they are on production.

Associated Issues and/or People

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit 7a26019
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/65fa075fec40c80008d7bd82
😎 Deploy Preview https://deploy-preview-251--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yvonnetangsu yvonnetangsu marked this pull request as ready for review March 19, 2024 21:45
@yvonnetangsu
Copy link
Member Author

@sherakama I'm going to merge this in and cut a release. Alexis has reviewed and looks like we're good to go. I've checked existing pages and this shouldn't mess anything up 🤠

@yvonnetangsu yvonnetangsu merged commit cec029a into dev Mar 19, 2024
5 checks passed
@yvonnetangsu yvonnetangsu deleted the feature/GIVCAMP-307_story-hero-variant branch March 19, 2024 23:20
Comment on lines +54 to +57
// Storyblok Native Color Picker
export type SbColorPickerType = {
color?: string;
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time using the Native Color Picker plugin field in Storyblok

@yvonnetangsu yvonnetangsu mentioned this pull request Mar 19, 2024
yvonnetangsu added a commit that referenced this pull request Apr 2, 2024
* dev: (34 commits)
  GIVCAMP-292 GIVCAMP-305 | Horizontal Initiative card and image aspect ratio options (#256)
  1.3.3
  Update robots to use different URL for sitemap path (#254)
  1.3.2
  GIVCAMP-307 | Stacked story hero variant (#251)
  1.3.1
  GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options (#248)
  Bump follow-redirects from 1.15.4 to 1.15.6 (#249)
  1.3.0
  GIVCAMP-289: Inline External Script Loading. (#246)
  GIVCAMP-88 | data card (#245)
  1.2.2
  GIVCAMP-294 | Basic Hero overlay options and image optimization (#243)
  HSTS set max-age to 31536000 (#242)
  1.2.1
  Icon animation (#240)
  GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239)
  1.2.0
  GIVCAMP-293 | Moment poster (#236)
  NoJira: Remove Editor Token (#237)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant