Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding scores #207

Merged
merged 7 commits into from
Jul 4, 2024
Merged

adding scores #207

merged 7 commits into from
Jul 4, 2024

Conversation

nikk-nikaznan
Copy link
Collaborator

@nikk-nikaznan nikk-nikaznan commented Jul 2, 2024

Adding prediction score during tracking inference to csv file. At the moment to VIA format csv, should we have simple csv option, if we not intend to do tracking labelling?

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 39.52%. Comparing base (bddd57a) to head (8182727).
Report is 1 commits behind head on main.

Files Patch % Lines
crabs/tracker/utils/io.py 0.00% 3 Missing ⚠️
crabs/tracker/track_video.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   39.49%   39.52%   +0.02%     
==========================================
  Files          24       24              
  Lines        1418     1417       -1     
==========================================
  Hits          560      560              
+ Misses        858      857       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig
Copy link
Collaborator

sfmig commented Jul 3, 2024

I think for now we can continue with using VIA tracks format as a standard, since we also assumed the users adhere to it to analyse the bboxes tracks in movement

Signed-off-by: nikk-nikaznan <48319650+nikk-nikaznan@users.noreply.github.com>
@nikk-nikaznan nikk-nikaznan marked this pull request as ready for review July 3, 2024 19:11
@nikk-nikaznan nikk-nikaznan requested a review from sfmig July 3, 2024 19:13
Copy link
Collaborator

@sfmig sfmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks loads!

A refactoring suggestion and a request to rename the output field (to amtch the movement dataloader).

crabs/tracker/utils/io.py Show resolved Hide resolved
crabs/tracker/utils/tracking.py Show resolved Hide resolved
tests/test_unit/test_tracking_utils.py Outdated Show resolved Hide resolved
nikk-nikaznan and others added 2 commits July 4, 2024 11:18
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Signed-off-by: nikk-nikaznan <48319650+nikk-nikaznan@users.noreply.github.com>
@nikk-nikaznan nikk-nikaznan merged commit 492d72a into main Jul 4, 2024
6 checks passed
@nikk-nikaznan nikk-nikaznan deleted the nikkna/detection-score branch July 4, 2024 10:35
sfmig added a commit that referenced this pull request Jul 8, 2024
* adding scores

* small changes how we save the score

* revert config

* fix test

* Update tests/test_unit/test_tracking_utils.py

Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Signed-off-by: nikk-nikaznan <48319650+nikk-nikaznan@users.noreply.github.com>

* changes based on review

---------

Signed-off-by: nikk-nikaznan <48319650+nikk-nikaznan@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants