-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ValidVIAtracksCSV class (2/4) #219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 99.71% 99.74% +0.02%
==========================================
Files 13 13
Lines 714 771 +57
==========================================
+ Hits 712 769 +57
Misses 2 2 ☔ View full report in Codecov by Sentry. |
d9b11c7
to
eb2b836
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WoW, what a titanic effort to define all those valdations and fixtures. But now you can be sure your parsing is tightly secure :)
Nothing substantial to comment here, other than the (now obvious) need for a fixture refactor, which you've mentioned yourself
Co-authored-by: Niko Sirmpilatze <niko.sirbiladze@gmail.com>
be7a384
to
24fbf3d
Compare
6ba5bca
to
be1c989
Compare
Quality Gate passedIssues Measures |
Description
What is this PR
Why is this PR needed?
We want to be able to load track bounding boxes annotations written in the VIA format.
What does this PR do?
It adds a
ValidVIAtracksCSV
class that validates VIA output files.The validator is a bit more strict in its checks than the currently existing ones. This is because when we later load the VIA file data into a bounding box class, we make assumptions about it that are not necessarily enforced in the annotator tool per se (e.g. having unique bounding boxes IDs per frame).
The checks are roughly:
The fixtures in
conftest.py
have increased quite a bit though, but I left that for a future PR (issue #222).References
#167
How has this PR been tested?
Tests pass locally and in CI.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
I updated
api_index.rst
(but this won't be needed anymore soon! 🥳 #213)Checklist: