Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in update_forecast_datasets worker #113

Merged
merged 6 commits into from
Oct 5, 2022
Merged

Fix bug in update_forecast_datasets worker #113

merged 6 commits into from
Oct 5, 2022

Conversation

douglatornell
Copy link
Member

re: issue #112

@douglatornell douglatornell added this to the v22.1 milestone Oct 4, 2022
@douglatornell douglatornell self-assigned this Oct 4, 2022
@douglatornell douglatornell linked an issue Oct 4, 2022 that may be closed by this pull request
Present day missing from ERDDAP depth-averaged currents dataset #112
Closed
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Merging #113 (bf12473) into main (4eba8d4) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   73.76%   73.82%   +0.05%     
==========================================
  Files         125      125              
  Lines       16243    16278      +35     
  Branches     1169     1164       -5     
==========================================
+ Hits        11982    12017      +35     
  Misses       4206     4206              
  Partials       55       55
Flag Coverage Δ
unittests 73.82% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nowcast/workers/update_forecast_datasets.py 98.54% <100.00%> (+0.01%) ⬆️
tests/workers/test_update_forecast_datasets.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglatornell
Change NowcastWorker mock to pytest fixture
7a877be 
re: issue #81
@douglatornell
Change logging mocks to pytest caplog fixture
1fcd136 
re: issue #82
@douglatornell
Change many @patch to pytest monkeypatch fixtures
e25faf8 
Remaining @patch decorators support things like Mock.call_args_list that
require deeper work to refactor.
@douglatornell
Fix bug re: rolling fcst missing today's CHS_currents.nc
d795c35 
re: issue #112
@douglatornell
Improve exclusion of files from rolling fcst tree
bf12473 
VENUS_*.nc files are excluded because they are not published on ERDDAP.
SalishSea_1d*.nc and *restart.nc files are now excluded from all directories
in the rolling forecast tree.

Closes #112
@douglatornell douglatornell marked this pull request as ready for review October 5, 2022 22:28
@douglatornell douglatornell merged commit 2d8512c into main Oct 5, 2022
@douglatornell douglatornell deleted the issue112--erddap-depth-averaged-currents branch October 5, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@douglatornell douglatornell

Labels
bug Something isn't working critical Model Results Workers
Projects
None yet
Milestone
v22.1
Development

Successfully merging this pull request may close these issues.

Present day missing from ERDDAP depth-averaged currents dataset
1 participant
@douglatornell