Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in update_forecast_datasets worker #113

Merged
merged 6 commits into from
Oct 5, 2022
Merged

Fix bug in update_forecast_datasets worker #113

merged 6 commits into from
Oct 5, 2022

Commits on Oct 4, 2022

  1. Update config(base_config) test fixture

    @douglatornell
    douglatornell committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    59078e5 View commit details
    Browse the repository at this point in the history

  2. Change NowcastWorker mock to pytest fixture 

    re: issue #81
    @douglatornell
    douglatornell committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    7a877be View commit details
    Browse the repository at this point in the history

  3. Change logging mocks to pytest caplog fixture 

    re: issue #82
    @douglatornell
    douglatornell committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    1fcd136 View commit details
    Browse the repository at this point in the history

  4. Change many @patch to pytest monkeypatch fixtures 

    Remaining @patch decorators support things like Mock.call_args_list that
require deeper work to refactor.
    @douglatornell
    douglatornell committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    e25faf8 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Fix bug re: rolling fcst missing today's CHS_currents.nc 

    re: issue #112
    @douglatornell
    douglatornell committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    d795c35 View commit details
    Browse the repository at this point in the history

  2. Improve exclusion of files from rolling fcst tree 

    VENUS_*.nc files are excluded because they are not published on ERDDAP.
SalishSea_1d*.nc and *restart.nc files are now excluded from all directories
in the rolling forecast tree.

Closes #112
    @douglatornell
    douglatornell committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    bf12473 View commit details
    Browse the repository at this point in the history