Add support for spatial audio #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fabian Fritzsche <salzian.dev@gmail.com>
Salzian
reviewed
Sep 22, 2023
| @@ -9,12 +9,18 @@ license = "MIT OR Apache-2.0" | |||
|
|
|||
| [dependencies] | |||
| anyhow = "1.0.75" | |||
| bevy = { version = "0.11.2", default-features = false } | |||
| bevy = { version = "0.11.2", default-features = false, features = ["bevy_audio"] } | |||
There was a problem hiding this comment.
We should add a test crate that depends on this crate to run unit tests and ensure the crate functions correctly as a library. With just examples, I assume this mistake wouldn't have been obvious.
There was a problem hiding this comment.
I haven't done much unit testing before (let alone with Rust) but that sounds reasonable
Cargo.toml
Outdated
| bevy_mod_sysfail = "3.0.0" | ||
| libfmod = "2.206.2" | ||
| once_cell = "1.18.0" |
There was a problem hiding this comment.
I can't see this being imported anywhere. Where is this used?
There was a problem hiding this comment.
Lol, no idea where this came from. It's removed now
Comment on lines
+15
to
+16
| match query.get_single() { | ||
| Ok((velocity, transform)) => { |
Salzian
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added example spatial.rs.
Adds components to handle FMOD events in a Bevy way, by implementing AudioSinkPlayback and storing a reference to the FMOD event.
Closes #1
Closes #21
Closes #16