Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bevy 0.12 #60

Merged
merged 17 commits into from
Dec 30, 2023
Merged

Update to Bevy 0.12 #60

merged 17 commits into from
Dec 30, 2023

Conversation

GitGhillie
Copy link
Collaborator

@GitGhillie GitGhillie commented Oct 21, 2023

Closes #59
The only relevant migration seems to be:
FixedTime to Time (Bevy pull 8964)

To do:

  • Test Doppler
  • Update Bevy dependency to 0.12
  • Remove smooth-bevy-cameras dev dependency so we don't have to wait for it (it got updated)

@GitGhillie GitGhillie added the dependencies Pull requests that update a dependency file label Oct 21, 2023
@GitGhillie
Copy link
Collaborator Author

Blocked on Bevy 0.12 release and #61, other than that it should be good to go

@GitGhillie GitGhillie marked this pull request as ready for review October 28, 2023 19:33
@GitGhillie
Copy link
Collaborator Author

Not blocking on 61 anymore since smooth-bevy-cameras got updated to 0.12

@pop
Copy link

pop commented Nov 8, 2023

@GitGhillie I think the README also needs to be updated if this version is compatible with Bevy 0.12.

@GitGhillie
Copy link
Collaborator Author

Thanks, I forgot about that! @Salzian did you want to do a final release before switching to 0.12? That will affect the version table.

src/components/velocity.rs Outdated Show resolved Hide resolved
@pop
Copy link

pop commented Dec 7, 2023

@GitGhillie @Salzian I can use this branch for now, but I would really appreciate this PR being merged so it officially supports Bevy 0.12. Is there anything I can do to help? Testing, etc?

@GitGhillie
Copy link
Collaborator Author

@pop we'll probably need to fix the issue mentioned above before it gets accepted. I put a small update in the thread if you want to look into it. Coming weekend I should have time to continue the investigation again

@GitGhillie
Copy link
Collaborator Author

Delaying the delta time by one frame fixed the unstable Doppler effect

@Salzian
Copy link
Owner

Salzian commented Dec 30, 2023

Accepting this for now, as I can't reproduce the unstable Doppler effect.

@Salzian Salzian merged commit ab3c6ac into main Dec 30, 2023
@Salzian Salzian deleted the update-0.12 branch December 30, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for Bevy 0.12
3 participants