Remove smooth-bevy-cameras dependency from spatial example #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salzian
previously approved these changes
Oct 21, 2023
|
Assuming you mean the spatial effect; I've now adjusted it so the cube is in view the whole time. Let me know what you think, I think it's better |
|
I guess this becomes obsolete with #60 ? Then we can close this PR. |
|
IMO it's still a good move, we'll run into the same issue when preparing for 0.13, 0.14, etc. |
Salzian
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to update bevy_fmod for new releases of Bevy.
Took some inspiration from the Bevy spatial example.
Feedback welcome!