Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified_english_spreadsheets #15

Draft
wants to merge 1 commit into
base: modifiedEnglishSpreadsheets
Choose a base branch
from

Conversation

Praj78
Copy link

@Praj78 Praj78 commented Aug 2, 2022

Hi Sammeeey, can u check this out

@Sammeeey
Copy link
Owner

Sammeeey commented Aug 2, 2022

Thank you for the contribution @Praj78 !
I assume that you have worked on the issues #11 & #13.

Did you if the software still works as intended with the modified spreadsheets?
I assume that it does not work since #13 says that #12 need to be solved upfront.

Sorry if this is confusing.
However if you have Python skills I recommend that you work on #12 first and solve #11 and #13 afterwards.

However it's great to have the translations for the spreadsheets already.
Thank you for your contribution.

@Sammeeey
Copy link
Owner

Sammeeey commented Aug 4, 2022

Some good practices for general open source contributions:

  • It's good practice to commit to a different branch other then the main branch of the project.
  • Don't create new directories and files if you are actually editing files. The beauty of version control like GitHub is that we can compare the changes easier if we just modify the existing files instead of creating new one's.
  • You can mention certain people in comments, pull requests and issues by using the @-character.
  • Keeping the conversation in an open source project public is important - so that everyone can follow the progress later.

@Sammeeey Sammeeey changed the base branch from main to modifiedEnglishSpreadsheets August 4, 2022 08:07
@Sammeeey Sammeeey self-requested a review August 4, 2022 08:07
@Sammeeey Sammeeey marked this pull request as draft August 4, 2022 08:11
Copy link
Owner

@Sammeeey Sammeeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the commit to point to the newly created modifiedEnglishSpreadsheets branch.

There are some important tasks left for you @Praj78.
Please complete the following tasks to finalize the commit:

  1. move the example spreadsheets to the existing example_spreadsheets folder.
    You may create two additional folders - one for the German and one for the English version of example spreadsheets.

  2. delete the pycache directories which you accidentally added

  3. I assume that the plzCrawler.py and plzMaker.py which you added in the plzcrawler_modified directory are originally the one's from the plzCrawler_en directory.
    Please move your .py files to the plzCrawler_en folder and delete the old one's instead.
    Otherwise I can't see the changes which you made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants