WIP: Rebase IoT.js on current upstream #2018

rzr · 2018-08-09T10:22:46Z

I tried to split changes to make tracking easier

Using HEAD was suggested by IoT.js's @zherczeg as latest release (1.0) is a bit old now

Note, this patch is pretty big and all changes have already been reviewed either upstream or downstream, so don't panic you can skip reviewing if agrea on strategy and commit messages.

Since TizenRT imported snapshot version of IoT.js (before 1.0), and patched over it, and to avoid drifting away IoT.js I am about to rebase on upstream then we will track downstream changes. Currently git modules are not used (to allow downstream patch), so a vanilla import is about to occur, on fresh base, (this is the reason I am previously deleting external/iotjs). Bug: Samsung#2018 Change-Id: I77a323334bc69d444a4f288c84f0e676a251250b Signed-off-by: Philippe Coval <p.coval@samsung.com>

This is a raw import of upstream latest release. It was imported using: git clone --recursive https://github.com/samsung/iotjs external/iotjs rm -rf external/iotjs/.git external/iotjs/.gitmodules rm -rf external/iotjs/deps/*/.git external/iotjs/deps/*/.gitmodules Bug: Samsung#2018 Origin: https://github.com/Samsung/iotjs/tree/release_1.0 Change-Id: I4d93e7c36e1afc1b528e337d7fcd1c3f7b9bdf8e Signed-off-by: Philippe Coval <p.coval@samsung.com>

This is an import from latest upstream codebase with upstream vanilla code. Note that downstream patches in Tizen:RT were dropped for different reasons: * some of them were applied in current version * patches are not applying anymore * or no more relevent. While other valid downstream patches will be applied again, and will be forwarded upstreamed for next import sync. Samsung#2018 Origin: jerryscript-project/iotjs@b2c741d Change-Id: I80f39a7f236d43ff5b1e458880fba49e93cf9985 Signed-off-by: Philippe Coval <p.coval@samsung.com>

description file is merge it to real header file Change-Id: I30a8e2d8772d7643b2113d7e40f87f885da4f3de Bug-TizenRT: Samsung#2018

@juitem

[Philippe Coval] While updating IoT.js in Tizen:RT, I noticed this downstream patch, it still applies to current version of IoT.js so I am forwarding it upstream in libtuv. To help tracking I am adding references to this changes. Author: Sanggyu Lee <sg5.lee@samsung.com> Bug-TizenRT: Samsung/TizenRT#2018 Cc: @juitem Cc: @glistening Change-Id: I16cbca383d4e5a7a8cc36eace93999a622f19adc Forwarded: Samsung#122 Origin: Samsung/TizenRT#744 libtuv-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com

@juitem

[Philippe Coval] While updating IoT.js in Tizen:RT, I noticed this downstream patch, it still applies to current version of IoT.js so I am forwarding it upstream in libtuv. To help tracking I am adding references to this changes. Author: Sanggyu Lee <sg5.lee@samsung.com> Bug-TizenRT: Samsung#2018 Cc: @juitem Cc: @glistening Change-Id: I16cbca383d4e5a7a8cc36eace93999a622f19adc Forwarded: Samsung/libtuv#122 Origin: Samsung#744 libtuv-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com

seinfra · 2018-08-09T10:29:37Z

Target : [2101d7b9f4a9b7404b02c8d5a4e1b78eca37fd61] -

seinfra · 2018-08-09T10:34:19Z

Target : [f34b7e0] - Code Rule Check (C++) OK.

seinfra · 2018-08-09T10:37:14Z

Target : [f34b7e0] - Code Rule Check OK.

@juitem

[Philippe Coval] While updating IoT.js in Tizen:RT, I noticed this downstream patch, it still applies to current version of IoT.js so I am forwarding it upstream in libtuv. To help tracking I am adding references to this changes. Author: Sanggyu Lee <sg5.lee@samsung.com> Bug-TizenRT: Samsung/TizenRT#2018 Cc: @juitem Cc: @glistening Change-Id: I16cbca383d4e5a7a8cc36eace93999a622f19adc Forwarded: Samsung#122 Origin: Samsung/TizenRT#744 libtuv-DCO-1.0-Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com

sunghan-chang · 2018-08-10T04:37:11Z

@rzr Is this discussed with IoTjs maintainers, @haesik and @hs0225 ?

sunghan-chang · 2018-08-10T04:41:00Z

@rzr Additionally Is external/iotjs/config/tizenrt/Kconfig.runtime alive in this PR?

sunghan-chang · 2018-08-10T07:29:44Z

@rzr I've asked @hs0225 about this PR. He said, he can't confirm it is ok or not (Previous one was fully tested on a board). I am not a maintainer of iotjs so that I can't merge that without confirmation of iotjs maintainer. Could you talk this at iotjs community?

rzr · 2018-08-10T08:05:12Z

Thanks for feedback, I knew that this patch will not go through without discussions first.

First let me comment about your questions

1/

Yes I have previously upstreamed TizenRT's Kconfig.runtime to IoT.js

tizenrt: Import Kconfig.runtime from TizenRT sources #1452
jerryscript-project/iotjs#1452

And prepared the transition in TizenRT:

WISH: iotjs: Sync iotjs upstream in Tizen:RT #1277
#1277

2/

About upstream coordination, I have announced in freenode my intention to update iotjs in TizenRT

<RzR> akiss, hi my patch went in, now I am trying to propose upgrade
<RzR> I noticed that some downstream patches werent forwarded to you
<RzR> I'll try to upstream thoses too
<RzR> zherczeg, hi I am talking about iotjs in Tizen:RT
<zherczeg> ok
<RzR> zherczeg, I'll keep you updated, let me know if you plan to tag a version soon, I'll double check that nothing is missing and make sure it will be easy to sync
<akiss> RzR: nice, looking forward
<akiss> thanks for the update
<RzR> you're welcome, I hope it will help cooperation and then we'll can consider to switch to git modules
<RzR> meanwhile I tried to split the changes in https://github.com/Samsung/TizenRT/pull/2018
<zherczeg> wow that is a huge patch
<RzR> it's a raw import
<RzR> don't panic
<RzR> code has been already reviewed

Should this be discussed elsewhere ?

Let me notify more IoT.js's upstream developers

https://github.com/Samsung/iotjs/graphs/contributors

cc: @ILyoan @hs0225 @yichoi @LaszloLango @galpeter @daeyeon @bzsolt @glistening @DanielBallaSZTE @haesik @rtakacs @12knightburton @seanshpark @robertsipka @chokobole @chunseoklee @nova0821 @zherczeg @19kolipka @akosthekiss

Do you see any objections to update IoT.js in Tizen:RT ?

3/

Regarding tests, I know that Tizen:RT is also tested upstream, ie:
https://travis-ci.org/Samsung/iotjs/jobs/411754512

Myself I've been using it on ARTIK055s for a couple of months (using http, adc, gpio modules)
and will give more details if curious.

@juitem

[Philippe Coval] While updating IoT.js in Tizen:RT, I noticed this downstream patch, it still applies to current version of IoT.js so I am forwarding it upstream in libtuv. To help tracking I am adding references to this changes. Author: Sanggyu Lee <sg5.lee@samsung.com> Bug-TizenRT: Samsung/TizenRT#2018 Cc: @juitem Cc: @glistening Change-Id: I16cbca383d4e5a7a8cc36eace93999a622f19adc Forwarded: #122 Origin: Samsung/TizenRT#744 libtuv-DCO-1.0-Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com

sunghan-chang · 2018-08-13T07:38:36Z

@rzr Thank you very much for your effort. But I discussed this with IoTjs dev team who is in HQ. He rejected this PR and he wants to raise an issue on IoTjs community (issue tab?). We should do public release ours and at that time we should get a test result from software engineering team. Because of that, it is difficult to update iotjs without confirmation from iotjs dev team.

akosthekiss · 2018-08-13T12:07:05Z

As I've been CC'd, I took a look at the commits. Except for the topmost SVACE fix, the rest seem to be TizenRT internal affairs (the update of IoT.js within TizenRT is the jurisdiction of TizenRT maintainers IMO). Moreover, the SVACE fix has landed in libtuv some hours ago, and the libtuv submodule of IoT.js has also been updated. With no downstream patches left, it seems there isn't anything left I could contribute to this PPR now.

rzr · 2018-08-13T13:03:35Z

thanks for feedback please hold this issue open a couple of weeks more because some of us are on vacation .

if needed i can open a ticket in iot.js tracker too and crosslink

sunghan-chang · 2018-08-13T22:26:24Z

@rzr I will. Thank you.

robertsipka · 2018-08-24T09:32:04Z

I think the topmost SVACE fix commit is incorrect and not necessary. That check should be after the allocation, where it is.

rzr · 2018-08-25T07:09:46Z

It was merged upstream, if libtuv could be improved let me suggest to commit there then the change will land is next IoT.js import sync.

ps: I plan to update this PR on a monthly basis until merged.

[Philippe Coval] While working along master branches of TizenRT and IoTjs, I observed that this patch was applied old version, This harmless change wasn't forwarded upstream, while can still even apply today. [Dongeon Kim] external/iotjs: merge description file Author: Dongeon Kim <devil.kim@samsung.com> Change-Id: I30a8e2d8772d7643b2113d7e40f87f885da4f3de Origin: Samsung/TizenRT#926 Bug-TizenRT: Samsung/TizenRT#2018 Forwarded: jerryscript-project#1733 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com

seinfra · 2019-01-15T16:19:43Z

Target : [b343eb870c22e3cf4fb74a0fad654496f3ad339b] - Code Rule Check (C++) OK.

seinfra · 2019-01-15T16:20:10Z

Target : [b343eb870c22e3cf4fb74a0fad654496f3ad339b] - Code Rule Check OK.

Change-Id: I691dfb825999b23dbe43084e0a2860fafaf84cba Origin: https://github.com/tizenteam/iotjs#sandbox/rzr/review/master Signed-off-by: Philippe Coval <p.coval@samsung.com>

This is a raw import of upstream latest release. It was imported using: git clone --recursive https://github.com/samsung/iotjs external/iotjs rm -rf external/iotjs/.git external/iotjs/.gitmodules rm -rf external/iotjs/deps/*/.git external/iotjs/deps/*/.gitmodules Bug: Samsung#2018 Origin: https://github.com/Samsung/iotjs/tree/release_1.0 Change-Id: I4d93e7c36e1afc1b528e337d7fcd1c3f7b9bdf8e Signed-off-by: Philippe Coval <p.coval@samsung.com>

Change-Id: I5e1a97a22fff3238edd6f110235dd40916e79722 Origin: https://github.com/pando-project/iotjs#master Bug: Samsung#2018 Signed-off-by: Philippe Coval <p.coval@samsung.com>

Change-Id: I36d3c6cb9b4208de1cd85c0b59340330cb4fefc8 Relate-to: jerryscript-project/iotjs#1777 Origin: https://github.com/pando-project/iotjs#master Signed-off-by: Philippe Coval <p.coval@samsung.com>

…pncpy() API This patch adds CONFIG_ARCH_STPNCPY support for stpncpy() API. Bug: Samsung#2415 Change-Id: Iafe9fa9ce6e6a6ae43fb2f2736dabbe2d81d5c3c Origin: Samsung@73d043b Signed-off-by: Vidisha Thapa <thapa.v@samsung.com>

They are already supported on TizenRT so that iotjs does not need to have them inside. Let's remove them. Bug: Samsung#2531 Change-Id: Iae161a6f353935e17d485eda55609d2033d43ccf Origin: Samsung@831b303 Signed-off-by: sunghan-chang <sh924.chang@samsung.com>

seinfra · 2019-04-18T12:41:57Z

Target : [cf34f6c] - Code Rule Check OK.

seinfra · 2019-04-18T12:42:11Z

Target : [cf34f6c] - Code Rule Check (C++) OK.

seinfra · 2019-04-24T12:02:38Z

Target : [cf34f6c] - Code Rule Check OK.

seinfra · 2019-04-24T12:10:46Z

Target : [cf34f6c] - Code Rule Check (C++) OK.

seinfra · 2019-04-24T12:20:07Z

Target : [cf34f6c] - Code Rule Check (C++) OK.

[Philippe Coval] While working along master branches of TizenRT and IoTjs, I observed that this patch was applied old version, This harmless change wasn't forwarded upstream, while can still even apply today. [Dongeon Kim] external/iotjs: merge description file Author: Dongeon Kim <devil.kim@samsung.com> Change-Id: I30a8e2d8772d7643b2113d7e40f87f885da4f3de Origin: Samsung/TizenRT#926 Bug-TizenRT: Samsung/TizenRT#2018 Forwarded: jerryscript-project#1733 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com

seinfra · 2019-11-12T08:24:41Z

Target : [cf34f6c] - Code Rule Check OK.

seinfra · 2019-11-12T08:30:23Z

Target : [cf34f6c] - Code Rule Check (C++) OK.

rzr · 2020-05-15T10:15:25Z

Is a new release of IoT.js planned anytime soon ?

sunghan-chang · 2020-07-06T08:42:41Z

@rzr Oh sorry for late reply. I found this now. As far as I know, no plan.

rzr · 2020-07-07T15:32:22Z

OK thanks for feedback, ping me if there are any interest to use updated iotjs on tizenrt,
Or I can try to upstream this for nuttx, I've been using this for webthings-iotjs

Relate-to: rzr/webthing-iotjs#7

rzr force-pushed the sandbox/rzr/review/master branch from 2101d7b to 116268f Compare August 9, 2018 10:25

rzr pushed a commit to TizenTeam/TizenRT that referenced this pull request Aug 9, 2018

external/iotjs: merge description file

358dfb8

description file is merge it to real header file Change-Id: I30a8e2d8772d7643b2113d7e40f87f885da4f3de Bug-TizenRT: Samsung#2018

rzr force-pushed the sandbox/rzr/review/master branch from 116268f to f34b7e0 Compare August 9, 2018 10:27

rzr mentioned this pull request Aug 13, 2018

wish: version release jerryscript-project/iotjs#1726

Closed

rzr force-pushed the sandbox/rzr/review/master branch from f38fe4a to b343eb8 Compare January 15, 2019 16:09

rzr and others added 6 commits April 18, 2019 14:27

external/iotjs: About to replace import

955060b

Change-Id: I691dfb825999b23dbe43084e0a2860fafaf84cba Origin: https://github.com/tizenteam/iotjs#sandbox/rzr/review/master Signed-off-by: Philippe Coval <p.coval@samsung.com>

external/iotjs: Import 'release_1.0-630-g5850192' (2019-01-15)

25be2b3

Change-Id: I5e1a97a22fff3238edd6f110235dd40916e79722 Origin: https://github.com/pando-project/iotjs#master Bug: Samsung#2018 Signed-off-by: Philippe Coval <p.coval@samsung.com>

external/iotjs: Import 'release_1.0-656-g10223e1' (2019-04-18)

e954dbf

Change-Id: I36d3c6cb9b4208de1cd85c0b59340330cb4fefc8 Relate-to: jerryscript-project/iotjs#1777 Origin: https://github.com/pando-project/iotjs#master Signed-off-by: Philippe Coval <p.coval@samsung.com>

rzr force-pushed the sandbox/rzr/review/master branch from b343eb8 to cf34f6c Compare April 18, 2019 12:29

sunghan-chang closed this May 15, 2020

rzr mentioned this pull request Jul 7, 2020

Integration in system/distro [meta] rzr/webthing-iotjs#7

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Rebase IoT.js on current upstream #2018

WIP: Rebase IoT.js on current upstream #2018

rzr commented Aug 9, 2018 •

edited

Loading

seinfra commented Aug 9, 2018

seinfra commented Aug 9, 2018

seinfra commented Aug 9, 2018

sunghan-chang commented Aug 10, 2018

sunghan-chang commented Aug 10, 2018

sunghan-chang commented Aug 10, 2018

rzr commented Aug 10, 2018 •

edited

Loading

sunghan-chang commented Aug 13, 2018

akosthekiss commented Aug 13, 2018

rzr commented Aug 13, 2018

sunghan-chang commented Aug 13, 2018

robertsipka commented Aug 24, 2018

rzr commented Aug 25, 2018

seinfra commented Jan 15, 2019

seinfra commented Jan 15, 2019

seinfra commented Apr 18, 2019

seinfra commented Apr 18, 2019

seinfra commented Apr 24, 2019

seinfra commented Apr 24, 2019

seinfra commented Apr 24, 2019

seinfra commented Nov 12, 2019

seinfra commented Nov 12, 2019

rzr commented May 15, 2020

sunghan-chang commented Jul 6, 2020

rzr commented Jul 7, 2020 •

edited

Loading

WIP: Rebase IoT.js on current upstream #2018

WIP: Rebase IoT.js on current upstream #2018

Conversation

rzr commented Aug 9, 2018 • edited Loading

seinfra commented Aug 9, 2018

seinfra commented Aug 9, 2018

seinfra commented Aug 9, 2018

sunghan-chang commented Aug 10, 2018

sunghan-chang commented Aug 10, 2018

sunghan-chang commented Aug 10, 2018

rzr commented Aug 10, 2018 • edited Loading

sunghan-chang commented Aug 13, 2018

akosthekiss commented Aug 13, 2018

rzr commented Aug 13, 2018

sunghan-chang commented Aug 13, 2018

robertsipka commented Aug 24, 2018

rzr commented Aug 25, 2018

seinfra commented Jan 15, 2019

seinfra commented Jan 15, 2019

seinfra commented Apr 18, 2019

seinfra commented Apr 18, 2019

seinfra commented Apr 24, 2019

seinfra commented Apr 24, 2019

seinfra commented Apr 24, 2019

seinfra commented Nov 12, 2019

seinfra commented Nov 12, 2019

rzr commented May 15, 2020

sunghan-chang commented Jul 6, 2020

rzr commented Jul 7, 2020 • edited Loading

rzr commented Aug 9, 2018 •

edited

Loading

rzr commented Aug 10, 2018 •

edited

Loading

rzr commented Jul 7, 2020 •

edited

Loading