This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
Fix SVACE defect in IoT.js (fs.scandir) #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
force-pushed
the
sandbox/pcoval/on/master/review
branch
from
a40c0b7 to
e716aa8
Compare
rzr
added a commit
to TizenTeam/libtuv
that referenced
this pull request
Aug 9, 2018
[Philippe Coval] While updating IoT.js in Tizen:RT, I noticed this downstream patch, it stills applies to current version of IoT.js so I am forwarding it upstream. To help crosstracking a Change-Id and some references add. Author: Sanggyu Lee <sg5.lee@samsung.com> Change-Id: I16cbca383d4e5a7a8cc36eace93999a622f19adc Forwarded: Samsung#122 Origin: Samsung/TizenRT@51262d2 libtuv-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/pcoval/on/master/review
branch
from
e716aa8 to
07cc1f7
Compare
rzr
added a commit
to TizenTeam/libtuv
that referenced
this pull request
Aug 9, 2018
[Philippe Coval] While updating IoT.js in Tizen:RT, I noticed this downstream patch, it still applies to current version of IoT.js so I am forwarding it upstream in libtuv. To help tracking I am adding references to this changes. Author: Sanggyu Lee <sg5.lee@samsung.com> Bug-TizenRT: Samsung/TizenRT#2018 Cc: @juitem Cc: @glistening Change-Id: I16cbca383d4e5a7a8cc36eace93999a622f19adc Forwarded: Samsung#122 Origin: Samsung/TizenRT#744 libtuv-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
added a commit
to TizenTeam/TizenRT
that referenced
this pull request
Aug 9, 2018
[Philippe Coval] While updating IoT.js in Tizen:RT, I noticed this downstream patch, it still applies to current version of IoT.js so I am forwarding it upstream in libtuv. To help tracking I am adding references to this changes. Author: Sanggyu Lee <sg5.lee@samsung.com> Bug-TizenRT: Samsung#2018 Cc: @juitem Cc: @glistening Change-Id: I16cbca383d4e5a7a8cc36eace93999a622f19adc Forwarded: Samsung/libtuv#122 Origin: Samsung#744 libtuv-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
[Philippe Coval] While updating IoT.js in Tizen:RT, I noticed this downstream patch, it still applies to current version of IoT.js so I am forwarding it upstream in libtuv. To help tracking I am adding references to this changes. Author: Sanggyu Lee <sg5.lee@samsung.com> Bug-TizenRT: Samsung/TizenRT#2018 Cc: @juitem Cc: @glistening Change-Id: I16cbca383d4e5a7a8cc36eace93999a622f19adc Forwarded: Samsung#122 Origin: Samsung/TizenRT#744 libtuv-DCO-1.0-Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com
rzr
force-pushed
the
sandbox/pcoval/on/master/review
branch
from
07cc1f7 to
d31217b
Compare
robertsipka
added a commit
to robertsipka/libtuv
that referenced
this pull request
Aug 24, 2018
The check should be after the allocation, where it is. It was misplaced and also duplicated the existing one. libtuv-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
added a commit
to robertsipka/libtuv
that referenced
this pull request
Aug 24, 2018
The check should be after the allocation, where it is. It was misplaced and also duplicated the existing one. libtuv-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
yichoi
pushed a commit
that referenced
this pull request
Aug 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Philippe Coval]
While updating IoT.js in Tizen:RT,
I noticed this downstream patch,
it stills applies to current version of IoT.js
so I am forwarding it upstream.
To help crosstracking a Change-Id and some references add.
Author: Sanggyu Lee sg5.lee@samsung.com
Origin: Samsung/TizenRT@51262d2
Change-Id: I16cbca383d4e5a7a8cc36eace93999a622f19adc
libtuv-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com