This repository has been archived by the owner on Jul 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
PR: Fixes issues with Permissions, and completes it's improvements #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
U mad lad. |
Can I check it out tomorrow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature and Bug Fixes Pull Request
This Pull Request addresses issues that started happening as a result of the latest bug fix, which gave permissions (aka /f perm) priority and total functionality over factions behavior. The fixes being addressed in this Pull Request are as follows:
More over, this pull request also brings improvements to code-quality, described as follows:
And finally, a little feature:
Issues that helped to address this pull request
#130 Even though issue was being attended by the time of this submission, it can now be closed.
#129 This was about to come in the next release, which is now stable.
#127 This was because of an issue described above.
#109 Was addressed before, but yet not getting the expected behavior.
What has changed
Most noticeable changes can be found at FactionsPlayerListener.java and FactionsBlockListener.java, which contains most of the permission validations for the abilities to build, destroy, and use certain materials. This two files were modified about the 15% of it, and the re work has been successfully tested on a development server, giving the expected results.
Purpose of this Pull Request
The idea of this pull request was mainly to address all of the issues left by the latest merge, which applied security patches on permission usage. This changes are important for a coherent behavior of factions, and it's customization by the users of it. But this is also part of a enhancement process, to improve code-quality and readability of the source code.
BEFORE UPDATING
Please note that the state of this pull request, contains sensitive changes that may affect the gameplay if you are updating from a previous release. So please consider the following when trying to update: