schema(geojson): Refresh #2769
Closed
schema(geojson): Refresh #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add mkdocs schema (#1) * Added mkdocs schema * Added test for mkdocs-1.0 * Rename mkdocs.yml to mkdocs-test.yml * Added mkdocs-1.0 to catalog.json * Insert final new line to mkdocs-1.0.json * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update mkdocs-1.0.json `Error: strict mode: missing type "object" for keyword "properties" at "#/definitions/coreProperties" (strictTypes)` * Update mkdocs-1.0.json `Error: strict mode: use allowUnionTypes to allow union type keyword at "#/definitions/coreProperties/properties/nav/items" (strictTypes)` * Update mkdocs-1.0.json `Error: strict mode: missing type "object" for keyword "required" at "#/allOf/1" (strictTypes)` --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
hyperupcall
force-pushed
the
fix-geojson
branch
from
7b3b368
to
e95937c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #2751 by updating the GeoJSON schema and moving the two GeoJSON entries close to each other in
catalog.jsonto make it clear that there is a duplicate.More work needs to be done, related to #2731, to completely solve this issue. In
schema-validation.json, there is an entry:{ "ninjs-2.0.json": { "unknownKeywords": ["name"], "externalSchema": ["geojson.json"] } }So we cannot just remove the
geojson.jsonexternal schema completely. To fix this issue, there needs to be some way of referencing external schemas without breaking the tests.Closes #1371 (that issue has been resolved an is not an issue with schemastore)