Mark as unread #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chandi <git@chandi.it>
Signed-off-by: chandi <git@chandi.it>
Signed-off-by: chandi <git@chandi.it>
Signed-off-by: chandi <git@chandi.it>
Signed-off-by: chandi <git@chandi.it>
Conflicts: src/components/structures/TimelinePanel.tsx src/components/views/rooms/RoomTile.tsx src/stores/notifications/RoomNotificationState.ts
From Google's material design icons: https://fonts.google.com/icons?selected=Material+Icons&icon.query=eye License: https://google.github.io/material-design-icons/ "We have made these icons available for you to incorporate them into your products under the Apache License Version 2.0. Feel free to remix and re-share these icons and documentation in your products. We'd love attribution in your app's about screen, but it's not required. The only thing we ask is that you not re-sell the icons themselves."
TypeError: Cannot read property 'getAccountData' of null
at d (Rooms.ts:160)
at e.removeUnreadMarker (TimelinePanel.tsx:884)
at e.<anonymous> (TimelinePanel.tsx:1140)
at ui (react-dom.production.min.js:131)
at ps (react-dom.production.min.js:220)
at wc (react-dom.production.min.js:259)
at t.unstable_runWithPriority (scheduler.production.min.js:18)
at jo (react-dom.production.min.js:122)
at xc (react-dom.production.min.js:252)
at pc (react-dom.production.min.js:243)
when you have the panel for mentions open.
This can get in the way of the "marked as unread" icon otherwise. Furthermore, I didn't really like it showing there persistently either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SchildiChat/schildichat-desktop#109
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.