Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2867: Marking rooms as unread #2867

Merged
merged 7 commits into from
Jun 24, 2024
Merged

MSC2867: Marking rooms as unread #2867

merged 7 commits into from
Jun 24, 2024

Conversation

Bubu
Copy link
Contributor

@Bubu Bubu commented Nov 17, 2020 •
edited by richvdh
Loading

@turt2live turt2live changed the title marking rooms as unread MSC2867: Marking rooms as unread Nov 17, 2020
@turt2live turt2live added kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal proposal-in-review labels Nov 17, 2020
@Bubu Bubu force-pushed the unread_rooms branch 2 times, most recently from c401fc2 to 8495e0b Compare November 17, 2020 21:51
@Bubu
marking rooms as unread
fee6f86 
Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Dec 5, 2020
@SpiritCroc
Possibility to mark rooms as unread
b2708b3 
Using com.famedly.marked_unnread, as per [MSC2867](matrix-org/matrix-spec-proposals#2867)

TODO:
- Currently, when upgrading from an older version, already existing
  unread flags are ignored until cache is cleared manually

Change-Id: I3b66fadb134c96f0eb428afd673035d790c16340
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Dec 5, 2020
@SpiritCroc
Possibility to mark rooms as unread
3fb2df7 
Using com.famedly.marked_unnread, as per MSC2867
(matrix-org/matrix-spec-proposals#2867)

TODO:
- Currently, when upgrading from an older version, already existing
  unread flags are ignored until cache is cleared manually

Change-Id: I3b66fadb134c96f0eb428afd673035d790c16340
Kirchmaus pushed a commit to SchildiChat/SchildiChat-android that referenced this pull request Dec 9, 2020
@SpiritCroc
Possibility to mark rooms as unread
3e4f6a4 
Using com.famedly.marked_unnread, as per MSC2867
(matrix-org/matrix-spec-proposals#2867)

TODO:
- Currently, when upgrading from an older version, already existing
  unread flags are ignored until cache is cleared manually

Change-Id: I3b66fadb134c96f0eb428afd673035d790c16340
@tulir
Copy link
Member

tulir commented Mar 19, 2021

This has been implemented in the Beeper app

@alangecker alangecker mentioned this pull request Jul 4, 2021
Closed
@su-ex
Copy link

su-ex commented Nov 26, 2021

Next SchildiChat Web/Desktop release will have this too.

@ShadowJonathan ShadowJonathan mentioned this pull request Jan 14, 2022
Open
4 tasks
@SpiritCroc SpiritCroc mentioned this pull request Nov 5, 2022
Closed
@phipz phipz mentioned this pull request Mar 14, 2023
Open
@manuroe manuroe mentioned this pull request Jan 10, 2024
Closed
9 tasks
@stefanceriu stefanceriu mentioned this pull request Jan 19, 2024
Closed
4 tasks
@jplatte jplatte mentioned this pull request Jan 26, 2024
Merged
@stefanceriu stefanceriu mentioned this pull request Jan 31, 2024
Merged
@dbkr dbkr mentioned this pull request Feb 15, 2024
Merged
3 tasks
@stefanceriu stefanceriu mentioned this pull request Feb 21, 2024
Merged
anoadragon453
anoadragon453 approved these changes Jun 18, 2024
View reviewed changes
proposals/2867-rooms_marked_unread.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversely, this feature has been asked for for years and while simple, I think it covers the majority of use cases. I vote for getting this in to people's hands. In the future we can always migrate to something more powerful if that ends up being warranted.

aka. let's avoid letting perfect be the enemy of good and iterate instead of blocking further.

@mscbot
Copy link
Collaborator

mscbot commented Jun 18, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jun 18, 2024
@Bubu @richvdh
Update proposals/2867-rooms_marked_unread.md
f897922 
grammar improvement

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@mscbot
Copy link
Collaborator

mscbot commented Jun 23, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jun 23, 2024
@turt2live turt2live merged commit a0ef90e into matrix-org:old_master Jun 24, 2024
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jun 24, 2024
turt2live added a commit that referenced this pull request Jun 24, 2024
@Bubu @turt2live
@anoadragon453 @richvdh
MSC2867: Marking rooms as unread (#2867)
d04470e 
* marking rooms as unread

Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>

* Add alternative suggestion by @turt2live

Co-authored-by: Travis Ralston <travpc@gmail.com>

* mention that this msc lacks thread support

* typo fix

* clarify type of notification we are referring to

* fix some small typos

* Update proposals/2867-rooms_marked_unread.md

grammar improvement

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

---------

Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Johennes added a commit to Johennes/matrix-spec that referenced this pull request Jul 1, 2024
@Johennes
Spec for MSC2867 (Marking rooms as unread)
877e037 
Relates to: matrix-org/matrix-spec-proposals#2867
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes mentioned this pull request Jul 1, 2024
Merged
3 tasks
@turt2live turt2live mentioned this pull request Jul 2, 2024
Open
@tulir
Copy link
Member

tulir commented Jul 9, 2024

Spec PR: matrix-org/matrix-spec#1895

@tulir tulir added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Jul 9, 2024
@clokep clokep added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jul 15, 2024
@turt2live
Copy link
Member

Merged 🎉

@zecakeh zecakeh mentioned this pull request Sep 5, 2024
Closed
41 tasks
@zecakeh zecakeh mentioned this pull request Oct 7, 2024
Merged
This was referenced Oct 8, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpiritCroc SpiritCroc SpiritCroc left review comments

@tulir tulir tulir left review comments

@richvdh richvdh richvdh left review comments

@gabrc52 gabrc52 gabrc52 left review comments

@clokep clokep clokep left review comments

@turt2live turt2live turt2live approved these changes

@uhoreg uhoreg uhoreg left review comments

@dbkr dbkr dbkr left review comments

@stefanceriu stefanceriu stefanceriu left review comments

@alphapapa alphapapa alphapapa left review comments

@ShadowJonathan ShadowJonathan ShadowJonathan left review comments

@ara4n ara4n ara4n left review comments

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
Status: Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.