Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement WaWi input replacement follow-up #2308

Closed
9 of 17 tasks
JoCa96 opened this issue Dec 11, 2024 · 0 comments
Closed
9 of 17 tasks

Implement WaWi input replacement follow-up #2308

JoCa96 opened this issue Dec 11, 2024 · 0 comments
Assignees
@JoCa96
Labels
cooperation Issues for projects in cooperative mode dev Requires technical expertise
Milestone
Inputs

Comments

@JoCa96
Copy link
Collaborator

JoCa96 commented Dec 11, 2024 •
edited
Loading

Why?

We determined which discrepancies between WaWi and onyx exists:

Open questions / TODOs

  • We will meet with the WaWi UI/UX team on Friday. Then we will present the current PoC state and afterward decide on the specifics.

Depends on

Acceptance criteria

The following topics are made possible via onyx changes and discussions

significant:

  • noTruncation property in onyx => todo
  • isMaxLengthDisplayed not in onyx => discuss
  • rightIcon not yet available in onyx => todo
  • trailing/trailingLabel not in onyx => todo
  • different error behavior => discuss
  • no focus(), select() => todo

minor:

  • Different maxlength visualization => discuss
  • Different readonly visualization => discuss

Implementation details

The currrent PoC is pushed to the jlc/poc-onyx-wux-input branch

Definition of Done

  • Should be covered by tests:

    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)

  • Make sure, that

    • follow-up tickets were created if necessary
    • updated version + documentation is deployed
    • Storybook can show the feature
    • Storybook code snippet of new/changed examples are checked that they are generated correctly
    • Namings are aligned with Figma

Approval

Storybook
Documentation

  • Checked and approved by
    • designer
    • dev
@JoCa96 JoCa96 added the dev Requires technical expertise label Dec 11, 2024
@JoCa96 JoCa96 added this to onyx Dec 11, 2024
@github-project-automation github-project-automation bot moved this to New in onyx Dec 11, 2024
@JoCa96 JoCa96 mentioned this issue Dec 11, 2024
Closed
5 tasks
@JoCa96 JoCa96 moved this from New to Backlog in onyx Dec 11, 2024
@JoCa96 JoCa96 self-assigned this Dec 11, 2024
@JoCa96 JoCa96 added the 0-refinement All issues that can or need to be estimated in our next refinement label Dec 11, 2024
@mj-hof mj-hof moved this from Backlog to Ready in onyx Dec 11, 2024
@mj-hof mj-hof removed the 0-refinement All issues that can or need to be estimated in our next refinement label Dec 11, 2024
@mj-hof mj-hof added this to the Inputs milestone Dec 11, 2024
@mj-hof mj-hof added the cooperation Issues for projects in cooperative mode label Dec 13, 2024
@JoCa96 JoCa96 moved this from Ready to In Progress in onyx Dec 16, 2024
@JoCa96 JoCa96 mentioned this issue Dec 16, 2024
Merged
larsrickert pushed a commit that referenced this issue Dec 18, 2024
@JoCa96
feat(i18n): Custom translation function can now be static (#2347)
2d87351 
Relates to #2308
@JoCa96 JoCa96 mentioned this issue Jan 7, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 7, 2025
@JoCa96
feat: expose internal inputs (#2439)
c7c3296 
Relates to #2308

Expose input elements of form elements, so that the native functions
like `focus` or `select` can be used.
@JoCa96 JoCa96 mentioned this issue Jan 9, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 10, 2025
@JoCa96 @github-actions
feat(OnyxInput): implement basic inline slots (#2469)
c17ccf7 
Relates to #2308 

Adds the slots `leading` and `trailing` based on the available figma
design to the `OnyxInput`

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: JoCa96 <18483883+JoCa96@users.noreply.github.com>
@JoCa96 JoCa96 mentioned this issue Jan 14, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 15, 2025
@JoCa96
fix(OnyxInput, OnyxTextarea): maxlength doesn't restrict the user f…
808e638 
…rom typing more than the allowed characters anymore (#2498)

Relates to #2308 

- `maxlength` doesn't restrict the user anymore from typing more than
the allowed characters.
- This is preferable, as the user can now paste or write content without
it being cut off.
- The previous behavior, which doesn't allow for typing/copying more
characters, can be achieved by setting `strictMaxlength`.
@JoCa96 JoCa96 mentioned this issue Jan 21, 2025
Merged
@JoCa96 JoCa96 moved this from In Progress to Done in onyx Jan 22, 2025
@JoCa96 JoCa96 closed this as completed Jan 22, 2025
@JoCa96 JoCa96 mentioned this issue Jan 22, 2025
Open
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 24, 2025
@JoCa96 @github-actions @ChristianBusshoff
feat: implement fallthrough attribute forwarding (#2566)
08c0057 
Relates to #2308 

- update `useRootAttrs` docs and make generic
- implement `useRootAttrs` for relevant components
- add vitepress docs for `useRootAttrs`

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: JoCa96 <18483883+JoCa96@users.noreply.github.com>
Co-authored-by: Christian Bußhoff <christian.busshoff@mail.schwarz>
JoCa96 added a commit that referenced this issue Jan 30, 2025
@JoCa96 @github-actions @ChristianBusshoff
feat: implement fallthrough attribute forwarding (#2566)
05d116a 
Relates to #2308 

- update `useRootAttrs` docs and make generic
- implement `useRootAttrs` for relevant components
- add vitepress docs for `useRootAttrs`

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: JoCa96 <18483883+JoCa96@users.noreply.github.com>
Co-authored-by: Christian Bußhoff <christian.busshoff@mail.schwarz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoCa96 JoCa96

Labels
cooperation Issues for projects in cooperative mode dev Requires technical expertise
Projects
onyx
Status: Done
Milestone
Inputs
Development

No branches or pull requests
2 participants
@JoCa96 @mj-hof