Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OnyxInput, OnyxTextarea): maxlength doesn't restrict the user from typing more than the allowed characters anymore #2498

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

JoCa96
Copy link
Collaborator

@JoCa96 JoCa96 commented Jan 14, 2025

Relates to #2308

  • maxlength doesn't restrict the user anymore from typing more than the allowed characters.
  • This is preferable, as the user can now paste or write content without it being cut off.
  • The previous behavior, which doesn't allow for typing/copying more characters, can be achieved by setting strictMaxlength.

@JoCa96 JoCa96 requested a review from a team as a code owner January 14, 2025 12:03
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 8e1ee9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Patch
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Patch
@sit-onyx/nuxt Patch
@sit-onyx/vitepress-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoCa96 JoCa96 changed the title fix(OnyxInput, OnyxTextarea): maxlength doesn't restrict the user from typing more than the allowed characters. fix(OnyxInput, OnyxTextarea): maxlength doesn't restrict the user from typing more than the allowed characters anymore Jan 14, 2025
@larsrickert larsrickert self-assigned this Jan 15, 2025
@JoCa96 JoCa96 added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 808e638 Jan 15, 2025
20 checks passed
@JoCa96 JoCa96 deleted the joca96/2308-input-lenient-max-length branch January 15, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants