Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

update munin configuration #716

Merged
merged 2 commits into from
Jan 18, 2019
Merged

update munin configuration #716

merged 2 commits into from
Jan 18, 2019

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Jan 17, 2019 •
edited
Loading

  • Update munin configuration

PR checklist

  • PR is made against dev branch
  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
  • CHANGELOG.md is updated

@maxulysse maxulysse self-assigned this Jan 17, 2019
alneberg
alneberg approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know where igenomes is stored on Munin, but I don't see any reason not to approve this.

@maxulysse
Copy link
Member Author

True, I should have asked martin or szilva to do this Review...
But I moved the files and tested it, so I'm pretty sure...

@alneberg
Copy link
Member

Yes, It wont brake anything for anyone else so its fine.

@maxulysse maxulysse merged commit 5a92b24 into SciLifeLab:dev Jan 18, 2019
@maxulysse maxulysse deleted the munin branch January 18, 2019 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alneberg alneberg alneberg approved these changes

Assignees

@maxulysse maxulysse

Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @alneberg