-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change states to unknowns #785
Conversation
I have fixed the Now, we do |
192ea76
to
3c23553
Compare
I think this is ready now, tried to update the MTK thing. Tests fail, but at least Catalyst compiles. Once: #749 we should be able to look at this now. I try to change "state" to "unknown" where it make sense. At some point when we are done with all of this, we'll have to go through from start to finish and ensure that we are consistent with what is a state, species, unknown, variable, and whatever. |
Tests fail though, it needs the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok to merge after addressing these minor comments. (I didn't check the changes within tests.)
docs/src/catalyst_applications/simulation_structure_interfacing.md
Outdated
Show resolved
Hide resolved
docs/src/catalyst_applications/simulation_structure_interfacing.md
Outdated
Show resolved
Hide resolved
docs/src/catalyst_applications/simulation_structure_interfacing.md
Outdated
Show resolved
Hide resolved
…g.md Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
…g.md Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
…g.md Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
We plan to handle this in a separate PR (on way), this one is needed to actually compile Catalyst though, hence we are sorting it out first. |
Then just merge when this is done, irrespective of the tests failing. |
4211485
to
93e08d0
Compare
Changes mentions of "states" to "unknowns".
Changes
get_states
(and similar functions) toget_unknowns
(and similar functions.I have tried to go through the full repo, and ensure that states such as in "steady state", or "the state of the system" are fine. Realistically, once all of this is over, I will probably have to read through the docs from start to finish to check that it reads consistently and nice. However, this should mostly be fine.
We cannot check whether this passes CI until MTK v9 is released. Also, CI will fail until we have figured SciML/ModelingToolkit.jl#2459 out.
We may/may not want to merge this into #757, but figured it would be easier to keep things somewhat separated for now.