Use MTK's default t and D throughout repository
#786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you change the base branch for all these PRs you are opening to v14 so they are readable? |
|
The other ones are to the v14 branch already, changed this one as well now. This one is based on #785 (because Catalyst cannot, currently, compile on ModelingToolkit#master without that one) |
TorkelE
force-pushed
the
use_mtk_default_t_and_D
branch
from
9fc9f22
to
d185e44
Compare
TorkelE
force-pushed
the
use_mtk_default_t_and_D
branch
from
d185e44
to
bf36cc7
Compare
isaacsas
reviewed
Mar 18, 2024
isaacsas
reviewed
Mar 18, 2024
isaacsas
reviewed
Mar 18, 2024
isaacsas
reviewed
Mar 18, 2024
isaacsas
requested changes
Mar 18, 2024
|
The rebase must have messed up, I will try to figure out and fix. |
isaacsas
reviewed
Mar 18, 2024
docs/src/catalyst_functionality/programmatic_CRN_construction.md
Outdated
Show resolved
Hide resolved
isaacsas
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v9, MTK creates default time and differential variables. This PRs make Catalyst use these (throughout tests and documentation). I.e. instead of
we now do
CI still cannot work due to
all_dimensionlessissue mentioned in #785 (which this one depends on).