-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MTK's default t
and D
throughout repository
#786
Conversation
Can you change the base branch for all these PRs you are opening to v14 so they are readable? |
The other ones are to the v14 branch already, changed this one as well now. This one is based on #785 (because Catalyst cannot, currently, compile on ModelingToolkit#master without that one) |
9fc9f22
to
d185e44
Compare
d185e44
to
bf36cc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please get rid of the unknown to state conversions that are for some reason in this PR. The ones here are not correct/desired.
The rebase must have messed up, I will try to figure out and fix. |
docs/src/catalyst_functionality/programmatic_CRN_construction.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the typo fix I just merged. Feel free to merge.
In v9, MTK creates default time and differential variables. This PRs make Catalyst use these (throughout tests and documentation). I.e. instead of
we now do
CI still cannot work due to
all_dimensionless
issue mentioned in #785 (which this one depends on).