-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add smoke test for ffjord #621
Conversation
Instead, just set |
Should I expand the tests and unroll the loop? (to use both |
Are all of the tests broken? |
Regardless of regularize=true & monte_carlo=false make errors and using GalacticOptim.AutoForwardDiff()
GalacticOptim.AutoReverseDiff()
GalacticOptim.AutoTracker() as |
What do you mean? |
oh with FFJORD, yes. |
It looks like this still isn't catching some of the errors? |
If we only use I think we have two choices:
I don't know whether there is any other choices. By second one, if someone wants to fix the errors, just changes it to |
(2) is a better way to go, because it's always better to fix and change from broken than have things documented in unmerged PRs. |
OK, I made the loop unrolled and also converted section comments to DiffEqFlux.jl/test/cnf_test.jl Lines 103 to 127 in 34c022f
but it doesn't use regularize=true !
|
I want to update other tests to more look like tests of this PR:
Can I update other tests in this PR? |
I made the updates. If you disagree, I will move them to new PR. |
Tests are failing. I just undo two last commits and will change other tests in a new PR. |
Thanks! |
I just added some smoke tests for ffjord to reveal errors related to some adtypes
It reveals errors that reported in #588, #610, #615, #624
This PR can be merged when these errors fixed