Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle edge cases where the gradients are nothing #918

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

avik-pal
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member

Add a test?

@avik-pal
Copy link
Member Author

Yes, give me 10 mins

@avik-pal avik-pal force-pushed the ap/param_edge_cases branch from 0630c23 to 65bd75e Compare October 19, 2023 23:56
@avik-pal avik-pal force-pushed the ap/param_edge_cases branch from 65bd75e to 406ae11 Compare October 20, 2023 01:00
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #918 (406ae11) into master (3586d36) will increase coverage by 0.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
+ Coverage   60.83%   61.08%   +0.25%     
==========================================
  Files          20       20              
  Lines        4478     4482       +4     
==========================================
+ Hits         2724     2738      +14     
+ Misses       1754     1744      -10     
Files Coverage Δ
src/parameters_handling.jl 30.55% <0.00%> (+11.80%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 1621f73 into master Oct 20, 2023
22 of 24 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/param_edge_cases branch October 20, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants