Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grib Py3 whats new #1806

Merged
merged 1 commit into from
Oct 14, 2015
Merged

Grib Py3 whats new #1806

merged 1 commit into from
Oct 14, 2015

Conversation

marqh
Copy link
Member

@marqh marqh commented Oct 12, 2015

replacing #1774 for now, noting the lack of support for GRIB in Python3

@pelson
Copy link
Member

pelson commented Oct 12, 2015

I'm not sure I agree with the statement, even if it is factually correct at the moment. The problem is that a future version of the GRIB_API could come along which does support Python3 - I can't be certain, but it looks to me like if that did happen we wouldn't need a new Iris version.

We aren't taking away functionality from users at this point, so I'd be inclined to just make a mention of GRIB not being available on Py3 yet, rather than it being a fundamental limitation of Iris.

@marqh
Copy link
Member Author

marqh commented Oct 13, 2015

i've updated the wording, is this any better?

pelson added a commit that referenced this pull request Oct 14, 2015
@pelson pelson merged commit 3e73b45 into SciTools:master Oct 14, 2015
@marqh marqh mentioned this pull request Oct 14, 2015
@pp-mo
Copy link
Member

pp-mo commented Nov 4, 2015

I know this is closed, but I'm puzzled..
The latest we have from @QuLogic (i.e. the branch https://github.com/QuLogic/iris/tree/py3k-grib) appears now to at least pass all the existing grib tests.
So, in the context of v1.9 release, @QuLogic @marqh : do we still need this warning, if the old code is still functional for now ?

@ajdawson
Copy link
Member

ajdawson commented Nov 4, 2015

I think we agreed that the change necessary to make GRIB work on Python 3 was not going to be included. The discussion is in the (closed) PR #1774 which is the py3k-grib branch you are referring to.

@pp-mo
Copy link
Member

pp-mo commented Nov 4, 2015

Thanks for explaining @ajdawson.
Sorry for a slip of the mouse : I meant to say https://github.com/QuLogic/iris/tree/py3k

But in any case, I think it is the same, if I misunderstood the status of this (and now have it right!)
I presume these commits are the contribution from py3k-grib, which will will not be including ?

e6b25f7 py3k: Re-set GRIB file loader after every message.
4fcd55a py3k: Be explicit about GRIB array type.

Assuming I've now got it, I'll add some python-3 specific skips to the things that break.

@ajdawson
Copy link
Member

ajdawson commented Nov 4, 2015

I believe that is accurate. If unsure I'd suggest you additionaly check with @rhattersley.

@rhattersley
Copy link
Member

It all looks good to me. 👍 Thanks for pushing this forwards! 😄

(FYI, work commitments have dragged me away from much active involvement recently and for the next month or so, but I'm very happy to spout opinions where that helps! 😉)

@QuLogic QuLogic added this to the v1.9.0 milestone Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants