-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip all grib tests for Python 3. #1833
Conversation
Looks good to me. |
if six.PY3: | ||
skip_grib = unittest.skipIf( | ||
True, | ||
'Test(s) use "grib", which is not currently supported under Python 3.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why grib
instead of gribapi
?
Good point -- I think I wasn't quite clear in my mind what it is that we have problems with in Python 3. |
cde1e9d
to
88ad62a
Compare
Following offline discussion with @marqh .. Rather than disable Iris grib usage in Python 3 (which only awaits a Python-3 functional gribapi), we have now instead removed the Python3 gribapi build from the scitools channel. So there is then no need to treat this as a special case : When installed under Python3 you have no gribapi, so it automatically skips the tests. |
... except it isn't working, for me. |
Are you sure it isn't working? I just ran all tests without |
I think the problem may be local to my installation: I expect you'll get #1842 "Enable Python 3" functioning any time soon. |
Dead, not needed now that #1842 has gone in. |
this is now a placeholder: DO NOT MERGE
see : #1833 (comment)
This excludes the grib tests from the standard test run in Python 3.This is needed because we decided not to support Grib under Python 3 for the present,
because of outstanding problems (see #1806).
TO TEST:running
python3 setup.py test
will generate various grib-related errors, which this removes.Unfortunately, all tests won't run successfully under Python 3, until various other outstanding problems are resolved (see list in #1782)