Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip all grib tests for Python 3. #1833

Closed
wants to merge 2 commits into from

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Nov 7, 2015

this is now a placeholder: DO NOT MERGE
see : #1833 (comment)

This excludes the grib tests from the standard test run in Python 3.
This is needed because we decided not to support Grib under Python 3 for the present,
because of outstanding problems (see #1806).

TO TEST:
running python3 setup.py test will generate various grib-related errors, which this removes.
Unfortunately, all tests won't run successfully under Python 3, until various other outstanding problems are resolved (see list in #1782)

@QuLogic QuLogic added this to the v1.9 milestone Nov 10, 2015
@QuLogic
Copy link
Member

QuLogic commented Nov 10, 2015

Looks good to me.

if six.PY3:
skip_grib = unittest.skipIf(
True,
'Test(s) use "grib", which is not currently supported under Python 3.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why grib instead of gribapi?

@pp-mo
Copy link
Member Author

pp-mo commented Nov 12, 2015

@rhattersley Why grib instead of gribapi?

Good point -- I think I wasn't quite clear in my mind what it is that we have problems with in Python 3.
Fixed.

@pp-mo pp-mo force-pushed the py3k-no-grib-tests branch from cde1e9d to 88ad62a Compare November 12, 2015 11:55
@pp-mo
Copy link
Member Author

pp-mo commented Nov 16, 2015

what it is that we have problems with in Python 3.

Following offline discussion with @marqh ..
It now seems we don't need this after all.

Rather than disable Iris grib usage in Python 3 (which only awaits a Python-3 functional gribapi), we have now instead removed the Python3 gribapi build from the scitools channel.

So there is then no need to treat this as a special case : When installed under Python3 you have no gribapi, so it automatically skips the tests.

@pp-mo pp-mo closed this Nov 16, 2015
@pp-mo pp-mo reopened this Nov 16, 2015
@pp-mo
Copy link
Member Author

pp-mo commented Nov 16, 2015

it automatically skips the tests.

... except it isn't working, for me.
I think an iris.proxy solution may be getting in the way.
cf : #1838 "Deprecate iris.proxy"
So something may still be needed here : but this commit is not it
this is now a placeholder: DO NOT MERGE...

@QuLogic
Copy link
Member

QuLogic commented Nov 18, 2015

Are you sure it isn't working? I just ran all tests without gribapi installed on Python 3.4 without any failures, except the one example that requires gribapi and isn't automatically skipped.

@pp-mo
Copy link
Member Author

pp-mo commented Nov 18, 2015

Are you sure it isn't working?

I think the problem may be local to my installation:
my conda is refusing to "forget" the gribapi build for Python3 that it used to have

I expect you'll get #1842 "Enable Python 3" functioning any time soon.
If so, that renders this obsolete + I'll close it.

@pp-mo
Copy link
Member Author

pp-mo commented Nov 19, 2015

Dead, not needed now that #1842 has gone in.

@pp-mo pp-mo closed this Nov 19, 2015
@pp-mo pp-mo deleted the py3k-no-grib-tests branch March 14, 2016 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants