-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colorbar
keyword for iris.quickplot routines
#6169
colorbar
keyword for iris.quickplot routines
#6169
Conversation
user to control automatic generation of a colorbar.
for more information, see https://pre-commit.ci
…ney/iris into feature/qplt_colorbar * 'feature/qplt_colorbar' of https://github.com/ukmo-ccbunney/iris: [pre-commit.ci] auto fixes from pre-commit.com hooks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6169 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 88 88
Lines 23178 23181 +3
Branches 4313 4313
=======================================
+ Hits 20818 20821 +3
Misses 1628 1628
Partials 732 732 ☔ View full report in Codecov by Sentry. |
@trexfeathers I've added 3 new tests for this change in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ukmo-ccbunney, I agree with your logic, please do put up that iris-test-data pull request - I assume you are following this guidance: Adding or Updating Graphics Tests — Iris 3.10.0 documentation (scitools-iris.readthedocs.io)
Oh and don't forget a What's New entry in |
Done; 8261d3b |
New test data for this change: SciTools/iris-test-data#94 |
* upstream/main: Make Iris backwards compatible with Cartopy (SciTools#6172) Updated environment lockfiles (SciTools#6173) Bump scitools/workflows from 2024.09.9 to 2024.10.0 (SciTools#6170) Update lock files, pin Cartopy!=0.23 (SciTools#6171)
Great! Now that iris-test-data is sorted, we need to reference 2.27 in the below places. While you're there, could you add a comment in iris/.github/workflows/ci-tests.yml Lines 52 to 54 in e9a7319
iris/.github/workflows/benchmarks_run.yml Lines 60 to 66 in e9a7319
|
* main: [pre-commit.ci] pre-commit autoupdate (SciTools#6175) Updated environment lockfiles (SciTools#6183) Update to `cell_method` parsing (SciTools#6083) Bump scitools/workflows from 2024.10.0 to 2024.10.1 (SciTools#6179) `colorbar` keyword for iris.quickplot routines (SciTools#6169) Make Iris backwards compatible with Cartopy (SciTools#6172) Updated environment lockfiles (SciTools#6173) Bump scitools/workflows from 2024.09.9 to 2024.10.0 (SciTools#6170) Update lock files, pin Cartopy!=0.23 (SciTools#6171)
🚀 Pull Request
Description
New boolean
colorbar
keywork allows user to control automatic generation of a colorbar in iris.quickplot plotting routines.Only implemented for
pcolormesh
,colormesh
andcoutourf
as the other plotting routines do not generate a colorbar.Fixes: #5970
Consult Iris pull request check list