Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Iris backwards compatible with Cartopy #6172

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.81%. Comparing base (e8c826a) to head (c7f4b08).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/iris/plot.py 45.45% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6172      +/-   ##
==========================================
- Coverage   89.83%   89.81%   -0.03%     
==========================================
  Files          88       88              
  Lines       23167    23178      +11     
  Branches     4310     4313       +3     
==========================================
+ Hits        20813    20818       +5     
- Misses       1623     1628       +5     
- Partials      731      732       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo pp-mo enabled auto-merge (squash) October 14, 2024 11:27
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why I have to review twice, but anyway.
Something odd there

@pp-mo pp-mo merged commit 54f430b into SciTools:main Oct 14, 2024
21 checks passed
@trexfeathers
Copy link
Contributor Author

Thanks @pp-mo!

ukmo-ccbunney added a commit to ukmo-ccbunney/iris that referenced this pull request Oct 15, 2024
* upstream/main:
  Make Iris backwards compatible with Cartopy (SciTools#6172)
  Updated environment lockfiles (SciTools#6173)
  Bump scitools/workflows from 2024.09.9 to 2024.10.0 (SciTools#6170)
  Update lock files, pin Cartopy!=0.23 (SciTools#6171)
stephenworsley added a commit to stephenworsley/iris that referenced this pull request Oct 22, 2024
* main:
  [pre-commit.ci] pre-commit autoupdate (SciTools#6175)
  Updated environment lockfiles (SciTools#6183)
  Update to `cell_method` parsing (SciTools#6083)
  Bump scitools/workflows from 2024.10.0 to 2024.10.1 (SciTools#6179)
  `colorbar` keyword for iris.quickplot routines (SciTools#6169)
  Make Iris backwards compatible with Cartopy (SciTools#6172)
  Updated environment lockfiles (SciTools#6173)
  Bump scitools/workflows from 2024.09.9 to 2024.10.0 (SciTools#6170)
  Update lock files, pin Cartopy!=0.23 (SciTools#6171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants