Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cargo-clippy step #5616

Closed
wants to merge 1 commit into from
Closed

Conversation

FirelightFlagboy
Copy link
Contributor

No description provided.

@FirelightFlagboy FirelightFlagboy requested a review from a team as a code owner October 24, 2023 07:48
with:
extra-args: clippy --verbose
- name: Check rust lint with cargo-clippy
run: cargo clippy --workspace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change modify the clippy arguments then:

- id: clippy
  name: clippy
  entry: cargo clippy
  language: system
  types: [ rust ]
  pass_filenames: false
  args:
    [
      --workspace,
      --tests,
      --bins,
      --lib,
      --exclude=libparsec_bindings_android,
      --exclude=libparsec_bindings_web,
      --exclude=libparsec_bindings_electron,
      --,
      --deny=warnings,
      --deny=clippy::undocumented_unsafe_blocks,
    ]

Is this okay ?

Copy link
Contributor Author

@FirelightFlagboy FirelightFlagboy Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, with this change, clippy would not run with the expected argument.

I'll wait for rust-lang/cargo#12115 to land on 1.75

@FirelightFlagboy
Copy link
Contributor Author

FirelightFlagboy commented Oct 24, 2023

cf #5616 (comment)

@FirelightFlagboy FirelightFlagboy deleted the simpler-clippy-step branch March 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants