Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cargo-clippy step #5616

Closed
wants to merge 1 commit into from
Closed

Simplify cargo-clippy step #5616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/ci-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,8 @@ jobs:

# Clippy basically compile the project, hence it's faster to run it in
# the test-rust-matrix job where compilation cache is reused !
- uses: ./.github/actions/use-pre-commit
with:
extra-args: clippy --verbose
- name: Check rust lint with cargo-clippy
run: cargo clippy --workspace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change modify the clippy arguments then:

- id: clippy
  name: clippy
  entry: cargo clippy
  language: system
  types: [ rust ]
  pass_filenames: false
  args:
    [
      --workspace,
      --tests,
      --bins,
      --lib,
      --exclude=libparsec_bindings_android,
      --exclude=libparsec_bindings_web,
      --exclude=libparsec_bindings_electron,
      --,
      --deny=warnings,
      --deny=clippy::undocumented_unsafe_blocks,
    ]

Is this okay ?

Copy link
Contributor Author

@FirelightFlagboy FirelightFlagboy Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, with this change, clippy would not run with the expected argument.

I'll wait for rust-lang/cargo#12115 to land on 1.75

timeout-minutes: 10

- name: Check rust code format
Expand Down