Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIMP: Using installer.script instead of original installer #1966

Merged
merged 4 commits into from
Aug 2, 2019

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Apr 4, 2019

Close #1369

Please consider merging ScoopInstaller/Scoop#3204, current unpack_inno crashed occasionally (due to Move-Item for huge amount of files).

@Ash258
Copy link
Contributor

Ash258 commented Apr 4, 2019

  • Unquoted $dir in Push-Location
  • Why both architecture scripts?

There could be one universal which could look like this:

Push-Location $dir
Get-ChildItem -Filter '*.debug' -Recurse | Remove-Item -Recurse
if ($architecture -eq '32') {
   Rename ,1 to twain
   Remove ,2
....
}

@niheaven
Copy link
Member Author

niheaven commented Apr 5, 2019

  • $dir is quoted.
  • The installer script has similar sections, but files manipulation and config setting are differ a lots:
    • 64bit
      • files have names as *,2*, *,3*
      • has a 32 dir, but need to copy two extra dirs into it.
      • python related files need to copy to 32
      • has a 32bit twain.exe (for 32bit plugins supports)
      • PATH config set to bin and 32\bin
    • 32bit
      • files have names as *,1*
      • move 32 over base dir
      • PATH config set to bin

So two scripts is prefered, otherwise it is too complex.

@niheaven
Copy link
Member Author

niheaven commented Apr 5, 2019

Or using pre_install, arch.installer.script, post_install.

pre_install for deleting .debug
post_install for set config
arch.install.er.script for others

@r15ch13 r15ch13 merged commit 8f9bdc2 into ScoopInstaller:master Aug 2, 2019
@niheaven niheaven deleted the fix-gimp branch August 2, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scoop-extras/gimp.json requires admin to install
3 participants